Skip to content

feat: update control update methods with change check #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jul 15, 2022

Provides alternative methods for update control to check if the resource and/or status sub-resource actually changed, and do the requests just in that case.

@csviri csviri self-assigned this Jul 15, 2022
@csviri csviri force-pushed the update_only_on_change branch from da3ec9d to a80c70c Compare July 26, 2022 07:34
@csviri csviri marked this pull request as ready for review July 27, 2022 08:22
@csviri csviri requested a review from metacosm July 27, 2022 08:25
@csviri csviri force-pushed the update_only_on_change branch from 0cfb8ec to a14fb3e Compare August 4, 2022 11:31
@csviri csviri changed the base branch from main to next August 4, 2022 11:32
@csviri csviri force-pushed the update_only_on_change branch from a14fb3e to d31ec17 Compare August 5, 2022 11:22
@csviri csviri force-pushed the update_only_on_change branch from d31ec17 to 91206c6 Compare August 23, 2022 09:15
@csviri csviri force-pushed the update_only_on_change branch from 91206c6 to 3a1960e Compare August 23, 2022 09:48
@csviri csviri force-pushed the update_only_on_change branch from 3a1960e to a5f2134 Compare August 25, 2022 08:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

41.8% 41.8% Coverage
0.0% 0.0% Duplication

@csviri csviri force-pushed the next branch 2 times, most recently from e2e3d77 to 331558b Compare August 30, 2022 08:09
@csviri
Copy link
Collaborator Author

csviri commented Sep 2, 2022

We decided to park this issue intil v4 where this behavior will be the default.

@csviri csviri added this to the 4.0 milestone Sep 2, 2022
Base automatically changed from next to main September 5, 2022 08:14
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2022
@github-actions
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants