Store mysql credentials in k8s secret #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mircea-cosbuc
force-pushed
the
mysql-sample/secret-credentials
branch
from
0e5ac3c to
56083dd
Compare
mircea-cosbuc
force-pushed
the
mysql-sample/secret-credentials
branch
from
56083dd to
ffbe962
Compare
adam-sandor
reviewed
Jun 23, 2020
...sql-schema/src/main/java/com/github/containersolutions/operator/sample/SchemaController.java
Show resolved
Hide resolved
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses https://github.com/ContainerSolutions/java-operator-sdk/issues/113 by creating a predictable MySQL user with granted privileges over the created schema. The credentials are stored as a K8s secret in the namespace where the schema is created.