Skip to content

Commit 6e224d4

Browse files
authored
improve: logging for informers (#1753)
1 parent cd46b28 commit 6e224d4

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,14 @@ public synchronized void stop() {
9898
@SuppressWarnings("rawtypes")
9999
private void logEventSourceEvent(NamedEventSource eventSource, String event) {
100100
if (log.isDebugEnabled()) {
101-
if (eventSource instanceof ResourceEventSource) {
102-
ResourceEventSource source = (ResourceEventSource) eventSource;
103-
log.debug("{} event source {} for {}", event, eventSource.name(),
101+
if (eventSource.original() instanceof ResourceEventSource) {
102+
ResourceEventSource source = (ResourceEventSource) eventSource.original();
103+
log.debug("{} event source {} for {}", event,
104+
eventSource.isNameSet() ? eventSource.name() : eventSource,
104105
source.resourceType());
105106
} else {
106-
log.debug("{} event source {}", event, eventSource.name());
107+
log.debug("{} event source {}", event,
108+
eventSource.isNameSet() ? eventSource.name() : eventSource);
107109
}
108110
}
109111
}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/NamedEventSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public EventSource eventSource() {
7272

7373
@Override
7474
public String toString() {
75-
return original + " named: '" + name + "'}";
75+
return original + " named: " + name;
7676
}
7777

7878
public EventSource original() {

0 commit comments

Comments
 (0)