-
Notifications
You must be signed in to change notification settings - Fork 25
Exposed endpoints for micrometer metrics #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposed endpoints for micrometer metrics #45
Conversation
I don't think that we should be making this change. It's up to users to decide how they want their metrics to be published. |
@metacosm - So, does that mean, we should not update the plugin and let the user know that they can use this feature? Then, we can update the tutorial accordingly. |
This can be shown as part of the tutorial and/or examples but I don't think it should be part of the code generated by the plug-in. |
Got your point. Thank you. |
Closing this. |
Metrics are enabled by default. You just need to provide a metrics provider. Which metrics provider is used should be up to the user. Do go operators automatically expose things over Prometheus? |
yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Added below changes in
pom.xml
fileIt will expose the metrics endpoints