Skip to content

modified the Quarkus operator SDK version and tutorial too #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 3, 2021
Merged

modified the Quarkus operator SDK version and tutorial too #40

merged 14 commits into from
Nov 3, 2021

Conversation

laxmikantbpandhare
Copy link
Member

modified the Quarkus operator SDK vesion and tutorial too

@laxmikantbpandhare laxmikantbpandhare self-assigned this Oct 20, 2021
@laxmikantbpandhare laxmikantbpandhare added documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation. labels Oct 20, 2021
jmrodri
jmrodri requested changes Oct 21, 2021
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to still manually create the crd.yaml? I thought the need for doing this manually was no longer true. Can you verify that the crd is being generated by maven now?

@metacosm
Copy link
Collaborator

I don't think that this PR is ready for merging. Also, if you want to be able to remove the main class, you'd have to keep using the 2.0.0 version.

@laxmikantbpandhare laxmikantbpandhare added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2021
@laxmikantbpandhare
Copy link
Member Author

Do we need to still manually create the crd.yaml? I thought the need for doing this manually was no longer true. Can you verify that the crd is being generated by maven now?

Yes, modified the content and added changes accordingly.

@laxmikantbpandhare laxmikantbpandhare removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2021
metacosm
metacosm reviewed Oct 30, 2021
View reviewed changes
tlwu2013
tlwu2013 reviewed Nov 3, 2021
View reviewed changes
Copy link
Contributor

@tlwu2013 tlwu2013 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we don't need these manual steps in the README to enable java-operator-plugins?
Shall we remove those unnecessary steps?

tlwu2013
tlwu2013 reviewed Nov 3, 2021
View reviewed changes
@tlwu2013
Copy link
Contributor

tlwu2013 commented Nov 3, 2021

Per chat @laxmikantbpandhare, I noticed there are a few deps are missing in the MemcachedController.java (and some in pom?) that causes build errors.

Please help take a look and include them into the tutorials too, thanks!

@laxmikantbpandhare
Copy link
Member Author

laxmikantbpandhare commented Nov 3, 2021 •
edited
Loading

Per chat @laxmikantbpandhare, I noticed there are a few deps are missing in the MemcachedController.java (and some in pom?) that causes build errors.

Please help take a look and include them into the tutorials too, thanks!

@tlwu2013 Updated the doc, please take a look at it.

tlwu2013
tlwu2013 approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@tlwu2013 tlwu2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified build pass, Operator successfully deployed and running on a cluster, Operand instances spinning up correctly.

LGTM! Thank you @laxmikantbpandhare!

@laxmikantbpandhare
Copy link
Member Author

Verified build pass, Operator successfully deployed and running on a cluster, Operand instances spinning up correctly.

LGTM! Thank you @laxmikantbpandhare!

@tlwu2013 thank you for helping with verification.

@laxmikantbpandhare laxmikantbpandhare merged commit 7b8aa82 into operator-framework:main Nov 3, 2021
@jmrodri jmrodri mentioned this pull request Feb 4, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlwu2013 tlwu2013 tlwu2013 approved these changes

@theishshah theishshah Awaiting requested review from theishshah

@jmrodri jmrodri Awaiting requested review from jmrodri

@metacosm metacosm Awaiting requested review from metacosm

Assignees

@laxmikantbpandhare laxmikantbpandhare

Labels
documentation Improvements or additions to documentation kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laxmikantbpandhare @metacosm @tlwu2013 @jmrodri