Fix lint issues

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

Author: Per Goncalves da Silva

pkg/client/actionclient_test.go

@@ -902,7 +902,7 @@ type mockPostRenderer struct {
 var _ postrender.PostRenderer = &mockPostRenderer{}
 
 func newMockPostRenderer(key, value string) PostRendererProvider {
-	return func(rm meta.RESTMapper, kubeClient kube.Interface, obj client.Object) postrender.PostRenderer {
+	return func(_ meta.RESTMapper, kubeClient kube.Interface, _ client.Object) postrender.PostRenderer {
 		return &mockPostRenderer{
 			k8sCli: kubeClient,
 			key:    key,

pkg/client/actionconfig.go

@@ -195,7 +195,7 @@ func (acg *actionConfigGetter) ActionConfigFor(ctx context.Context, obj client.O
 func getDebugLogger(ctx context.Context) func(format string, v ...interface{}) {
 	logger, err := logr.FromContext(ctx)
 	if err != nil {
-		return func(format string, v ...interface{}) {}
+		return func(_ string, _ ...interface{}) {}
 	}
 	return func(format string, v ...interface{}) {
 		logger.V(1).Info(fmt.Sprintf(format, v...))

pkg/client/actionconfig_test.go

@@ -166,7 +166,7 @@ metadata:
 			})
 
 			It("should use a custom rest config mapping", func() {
-				restConfigMapper := func(ctx context.Context, obj client.Object, cfg *rest.Config) (*rest.Config, error) {
+				restConfigMapper := func(_ context.Context, obj client.Object, _ *rest.Config) (*rest.Config, error) {
 					return &rest.Config{
 						BearerToken: obj.GetName(),
 					}, nil
@@ -192,7 +192,7 @@ metadata:
 			It("should use a custom storage driver", func() {
 				storageDriver := driver.NewMemory()
 
-				storageDriverMapper := func(ctx context.Context, obj client.Object, cfg *rest.Config) (driver.Driver, error) {
+				storageDriverMapper := func(_ context.Context, _ client.Object, _ *rest.Config) (driver.Driver, error) {
 					return storageDriver, nil
 				}
 				acg, err := NewActionConfigGetter(cfg, rm, StorageDriverMapper(storageDriverMapper))
@@ -209,7 +209,7 @@ metadata:
 
 				expected := &release.Release{Name: "test1", Version: 2, Info: &release.Info{Status: release.StatusDeployed}}
 				Expect(ac.Releases.Create(expected)).To(Succeed())
-				actual, err := storageDriver.List(func(r *release.Release) bool { return true })
+				actual, err := storageDriver.List(func(_ *release.Release) bool { return true })
 				Expect(err).ToNot(HaveOccurred())
 				Expect(actual).To(HaveLen(1))
 				Expect(actual[0]).To(Equal(expected))

pkg/reconciler/internal/hook/hook_test.go

@@ -92,17 +92,20 @@ var _ = Describe("Hook", func() {
 				Expect(err).To(HaveOccurred())
 			})
 			It("should fail with unknown owner kind", func() {
-				Expect(drw.Exec(owner, *rel, log)).To(MatchError(&meta.NoKindMatchError{
+				var err error = &meta.NoKindMatchError{
 					GroupKind:        schema.GroupKind{Group: "apps", Kind: "Deployment"},
 					SearchedVersions: []string{"v1"},
-				}))
+				}
+
+				Expect(drw.Exec(owner, *rel, log)).To(MatchError(err))
 			})
 			It("should fail with unknown dependent kind", func() {
 				rm.Add(schema.GroupVersionKind{Group: "apps", Version: "v1", Kind: "Deployment"}, meta.RESTScopeNamespace)
-				Expect(drw.Exec(owner, *rel, log)).To(MatchError(&meta.NoKindMatchError{
+				var err error = &meta.NoKindMatchError{
 					GroupKind:        schema.GroupKind{Group: "apps", Kind: "ReplicaSet"},
 					SearchedVersions: []string{"v1"},
-				}))
+				}
+				Expect(drw.Exec(owner, *rel, log)).To(MatchError(err))
 			})
 		})
 

pkg/reconciler/internal/values/values.go

@@ -32,7 +32,7 @@ var DefaultMaxReleaseHistory = 10
 
 var DefaultMapper = values.MapperFunc(func(v chartutil.Values) chartutil.Values { return v })
 
-var DefaultTranslator = values.TranslatorFunc(func(ctx context.Context, u *unstructured.Unstructured) (chartutil.Values, error) {
+var DefaultTranslator = values.TranslatorFunc(func(_ context.Context, u *unstructured.Unstructured) (chartutil.Values, error) {
 	return getSpecMap(u)
 })
 

pkg/reconciler/reconciler_test.go

@@ -120,7 +120,7 @@ var _ = Describe("Reconciler", func() {
 			Expect(err).ToNot(HaveOccurred())
 		})
 		It("should return an error if an option func fails", func() {
-			r, err := New(func(r *Reconciler) error { return errors.New("expect this error") })
+			r, err := New(func(_ *Reconciler) error { return errors.New("expect this error") })
 			Expect(r).To(BeNil())
 			Expect(err).To(MatchError("expect this error"))
 		})
@@ -415,7 +415,7 @@ var _ = Describe("Reconciler", func() {
 		})
 		_ = Describe("WithValueTranslator", func() {
 			It("should set the reconciler value translator", func() {
-				translator := values.TranslatorFunc(func(ctx context.Context, u *unstructured.Unstructured) (chartutil.Values, error) {
+				translator := values.TranslatorFunc(func(_ context.Context, _ *unstructured.Unstructured) (chartutil.Values, error) {
 					return chartutil.Values{"translated": true}, nil
 				})
 				Expect(WithValueTranslator(translator)(r)).To(Succeed())
@@ -934,7 +934,7 @@ var _ = Describe("Reconciler", func() {
 					})
 					When("value translator fails", func() {
 						BeforeEach(func() {
-							r.valueTranslator = values.TranslatorFunc(func(ctx context.Context, u *unstructured.Unstructured) (chartutil.Values, error) {
+							r.valueTranslator = values.TranslatorFunc(func(_ context.Context, _ *unstructured.Unstructured) (chartutil.Values, error) {
 								return nil, errors.New("translation failure")
 							})
 						})

pkg/storage/chunked_test.go

@@ -221,7 +221,7 @@ var _ = Describe("chunkedSecrets", func() {
 				MaxReadChunks:  1,
 				MaxWriteChunks: 2,
 			})
-			actual, err := maxReadDriver.List(func(rel *release.Release) bool { return true })
+			actual, err := maxReadDriver.List(func(_ *release.Release) bool { return true })
 			Expect(err).To(MatchError(ContainSubstring("release too large")))
 			Expect(actual).To(BeNil())
 		})