Bug 1936226 - [DevTools Release Tasks - Cycle 135] Remove backward compatibility code r=devtools-reviewers,nchevobbe

Differential Revision: https://phabricator.services.mozilla.com/D231674

Author: juliandescottes

devtools/client/fronts/descriptors/webextension.js

@@ -98,11 +98,8 @@ class WebExtensionDescriptorFront extends DescriptorMixin(
   }
 
   isServerTargetSwitchingEnabled() {
-    // @backward-compat { version 133 } Firefox 133 started supporting server targets by default.
-    // Once this is the only supported version, we can remove the traits and consider this true,
-    // but keep this method as some other descriptor still return false.
-    // At least the browser toolbox doesn't support server target switching.
-    return this.traits.isServerTargetSwitchingEnabled;
+    // Since Firefox 133, this is always true for webextension toolboxes.
+    return true;
   }
 
   getWatcher() {

devtools/client/fronts/targets/target-mixin.js

@@ -294,7 +294,7 @@ function TargetMixin(parentClass) {
             this._url;
       }
 
-      if (this.isWebExtension || this.isContentProcess) {
+      if (this.isContentProcess) {
         return this.targetForm.name;
       }
       return this.title;
@@ -315,18 +315,6 @@ function TargetMixin(parentClass) {
       );
     }
 
-    // @backward-compat { version 133 } Once 133 is released, this attribute can be removed.
-    // This will never be true anymore. Instead the usage in 'name' getter will be irrelevant
-    // as 'title' served by the backend will be correct for WebExtensions.
-    get isWebExtension() {
-      return !!(
-        this.targetForm &&
-        this.targetForm.actor &&
-        (this.targetForm.actor.match(/conn\d+\.webExtension(Target)?\d+/) ||
-          this.targetForm.actor.match(/child\d+\/webExtension(Target)?\d+/))
-      );
-    }
-
     get isContentProcess() {
       // browser content toolbox's form will be of the form:
       //   server0.conn0.content-process0/contentProcessTarget7

devtools/client/fronts/targets/window-global.js

@@ -82,10 +82,8 @@ class WindowGlobalTargetFront extends TargetMixin(
     event.isFrameSwitching = packet.isFrameSwitching;
 
     // Keep the title unmodified when a developer toolbox switches frame
-    // for a tab (Bug 1261687), but always update the title when the target
-    // is a WebExtension (where the addon name is always included in the title
-    // and the url is supposed to be updated every time the selected frame changes).
-    if (!packet.isFrameSwitching || this.isWebExtension) {
+    // for a tab (Bug 1261687).
+    if (!packet.isFrameSwitching) {
       this.setTitle(packet.title);
       this.setUrl(packet.url);
     }

devtools/server/actors/descriptors/webextension.js

@@ -115,9 +115,6 @@ class WebExtensionDescriptorActor extends Actor {
         supportsReloadDescriptor: true,
         // Supports the Watcher actor. Can be removed as part of Bug 1680280.
         watcher: true,
-        // @backward-compat { version 133 } Firefox 133 started supporting server targets by default.
-        // Once this is the only supported version, we can remove the traits and consider it always true in the frontend.
-        isServerTargetSwitchingEnabled: true,
       },
       url: this.addon.sourceURI ? this.addon.sourceURI.spec : undefined,
       warnings: lazy.ExtensionParent.DebugUtils.getExtensionManifestWarnings(

devtools/server/tests/xpcshell/test_webextension_descriptor.js

@@ -97,7 +97,6 @@ add_task(async function test_listAddons_and_WebExtensionDescriptor() {
         traits: {
           supportsReloadDescriptor: true,
           watcher: true,
-          isServerTargetSwitchingEnabled: true,
         },
       },
       "WebExtensionDescriptorActor content matches the add-on"