Last fix?

Author: benoit74

tests/zim/test_zim_creator.py

@@ -1008,6 +1008,59 @@ def test_blank_metadata(tmp_path):
         reader.get_text_metadata("None")
 
 
+@pytest.mark.parametrize(
+    "name,value,expected_value",
+    [
+        pytest.param(
+            "X-Test",
+            DEFAULT_DEV_ZIM_METADATA.Title + "Foo",
+            DEFAULT_DEV_ZIM_METADATA.Title + "Foo",
+            id="simple_str",
+        ),
+        pytest.param("X-Test", None, None, id="empty"),
+        pytest.param("Tags", ["tag1", "tag2"], "tag1;tag2", id="tags"),
+        pytest.param(
+            "LongDescription",
+            "Long \r\adescription",
+            "Long \rdescription",
+            id="long_description",
+        ),
+    ],
+)
+def test_add_metadata(tmp_path, name, value, expected_value):
+    fpath = tmp_path / "test_blank.zim"
+    with Creator(fpath, "").config_dev_metadata() as creator:
+        creator.add_metadata(name, value)
+    assert fpath.exists()
+    reader = Archive(fpath)
+    if value:
+        assert reader.get_text_metadata(name) == expected_value
+    else:
+        with pytest.raises(RuntimeError, match="Cannot find metadata"):
+            reader.get_text_metadata(name)
+
+
+@pytest.mark.parametrize(
+    "name",
+    [
+        pytest.param(
+            "Illustration_96x96@1",
+            id="illustration_@",
+        ),
+        pytest.param(
+            "Illustration_96x96_at_1",  # must be renamed to Illustration_96x96@1
+            id="illustration_at",
+        ),
+    ],
+)
+def test_add_bad_illustration(tmp_path, name):
+    with pytest.raises(
+        ValueError, match="Illustration_96x96@1 is not a 96x96 PNG Image"
+    ):
+        with Creator(tmp_path / "_.zim", "").config_dev_metadata() as creator:
+            creator.add_metadata(name, DEFAULT_DEV_ZIM_METADATA.Illustration_48x48_at_1)
+
+
 @pytest.mark.parametrize(
     "name,metadata_type,default_value,expected_value,expected_error",
     [