fixup! Ignore silently if file is already gone in delete callback

Author: benoit74

src/zimscraperlib/filesystem.py

@@ -7,13 +7,10 @@
 
 from __future__ import annotations
 
-import os
 import pathlib
 
 import magic
 
-from zimscraperlib import logger
-
 # override some MIME-types found by libmagic to different ones
 MIME_OVERRIDES = {
     "image/svg": "image/svg+xml",
@@ -44,9 +41,6 @@ def get_content_mimetype(content: bytes | str) -> str:
     return MIME_OVERRIDES.get(detected_mime, detected_mime)
 
 
-def delete_callback(fpath: str | pathlib.Path):
+def delete_callback(fpath: pathlib.Path):
     """helper deleting passed filepath"""
-    if not pathlib.Path(fpath).exists():
-        logger.warning(f"delete callback: file {fpath} is already gone")
-    else:
-        os.unlink(fpath)
+    fpath.unlink(missing_ok=True)

tests/filesystem/test_filesystem.py

@@ -54,4 +54,8 @@ def test_delete_callback(tmp_path):
 
     assert not fpath.exists()
 
+    # file already gone should not be a problem
+    delete_callback(fpath)
+
+    # wrong path should not be a problem
     delete_callback(pathlib.Path("/foo.txt"))

tests/zim/test_zim_creator.py

@@ -281,7 +281,7 @@ def test_sourcefile_removal(tmp_path, html_file):
 
 def test_sourcefile_removal_std(tmp_path, html_file):
     fpath = tmp_path / "test.zim"
-    paths = []
+    paths: list[pathlib.Path] = []
     with Creator(fpath, "").config_dev_metadata() as creator:
         for idx in range(0, 4):
             # copy html to folder