Skip to content

Commit 4a45384

Browse files
committed
Enhance save_large_file log level
On "decent" connections like we have when we run a scraper, "--progress=dot:giga" log level is sufficient to get a log at least once a second. More verbose progress is just filling logs with unnecessary details.
1 parent 5dfc065 commit 4a45384

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
### Added
1111

1212
- Add support for custom number of retries and user-agent in save_large_file (#278)
13+
- Enhance save_large_file log level (#279)
1314

1415
### Fixed
1516

src/zimscraperlib/download.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ def save_large_file(
136136
f"{retries}",
137137
"--retry-connrefused",
138138
"--random-wait",
139+
"--progress=dot:giga",
139140
"-O",
140141
str(fpath),
141142
"-c",

0 commit comments

Comments
 (0)