Fix compilation with last xcode version #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgautierfr
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #782 +/- ##
==========================================
- Coverage 56.07% 56.00% -0.07%
==========================================
Files 98 98
Lines 4394 4369 -25
Branches 1910 1901 -9
==========================================
- Hits 2464 2447 -17
Misses 672 672
+ Partials 1258 1250 -8
☔ View full report in Codecov by Sentry. |
|
libzim compile still fails |
|
@rgaudin We are compiling in C+11 for now (see #757). So I suspect other compilation errors being because you use a "too recent" version of gtest. |
mgautierfr
force-pushed
the
fix_last_xcode
branch
3 times, most recently
from
1142c81
to
5ba4a02
Compare
|
@mgautierfr Not a good idea to go straight to c++17 compat? |
|
As the commit message says, I'm not sure we should even move to c++14. Maybe or not but it should be made in #757. The last commit is just here to check if it compile with last xcode version or if there is other errors. |
|
@mgautierfr yes, please remove last commit and merge |
`std::binary_function` is deprecated in C++11. There is no need to replace it with something else. Just using a type with a `operator()` in the map is enough.
Constraints for REAL_TYPE<B> are : - Child of this class can be compared/incremented/... - Return type of the operator must be the child and not `REAL_TYPE<B>` The first point make us overloaded classic operators. This second point was making us templating the operator by `T` and not `REAL_TYPE<B>`. But it is to generic as we end define `operator-` for any type with `operator-=`. So we need to overload the operators for `NAME` (in the macro) and not use generics.
mgautierfr
force-pushed
the
fix_last_xcode
branch
from
5ba4a02
to
1b24d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #778 (hopefully this PR will be enough)
This PR fails on macOS because its compiler is recenter and stricter than others. The code needs to be slightly fixed to avoid the compiler complaining. Something necessary anyway if we want to move to C++14/17 like requested in #757.