From 5db399f39b96c62bab220974e1e2d6096c9a4854 Mon Sep 17 00:00:00 2001 From: Matthieu Gautier Date: Wed, 5 Apr 2023 11:30:37 +0200 Subject: [PATCH] Remove duplicated line in test/error_in_creator. Adding twice the same entry (metadata or not) will throw a exception. But we are testing async error here. If the async error not thrown in time because the writer thread is "slow", we will not catch the async error in time and we will throw the "wrong" exception. Should fix #775 --- test/error_in_creator.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/test/error_in_creator.cpp b/test/error_in_creator.cpp index 7788bf3d8..163024a25 100644 --- a/test/error_in_creator.cpp +++ b/test/error_in_creator.cpp @@ -291,7 +291,6 @@ TEST_P(FaultyDelayedItemErrorTest, faultyCompressedItem) zim::microsleep(sleep_time * getWaitTimeFactor()); // We detect it for any call after CHECK_ASYNC_EXCEPT(creator.addMetadata("Title", "This is a title")); - CHECK_ASYNC_EXCEPT(creator.addMetadata("Title", "This is a title")); CHECK_ASYNC_EXCEPT(creator.addIllustration(48, "PNGBinaryContent48")); CHECK_ASYNC_EXCEPT(creator.addRedirection("foo2", "FooRedirection", "foo")); CHECK_ASYNC_EXCEPT(creator.finishZimCreation());