From bdd0bdbb34488c05ec5a5a67a15bba25a191b295 Mon Sep 17 00:00:00 2001 From: PaglaDasu Date: Fri, 23 Feb 2024 15:49:30 +0530 Subject: [PATCH] Refactored shell scripts --- CHANGELOG.md | 1 + CONTRIBUTING.md | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c303f79..421f23e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fix caching of re-encoded video files (#82) - Do not start multiple video processing threads by default (`--processes` default value) (second part of #83) - Fix logging issue in DEBUG mode +- Refactored some shell scripts in `CONTRIBUTING.md` (#91) ## [1.1.1] - 2024-01-16 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4a90ee5..eb481ae 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,6 +36,7 @@ To simplify this, it is possible to: - iterate on ZIM UI code To achieve this, first build the Docker image based on current code base. +Make sure Docker is running in the background ("Docker Deamon" app for Windows and Mac, or `docker start` in Linux). ``` docker build -t local-kolibri2zim . @@ -44,7 +45,7 @@ docker build -t local-kolibri2zim . Scrape a channel (here we use the minimal channel, but you could use any other one of interest for your UI developments). ``` -docker run --rm -it -v $PWD/output:/output local-kolibri2zim kolibri2zim --name "minimal_test" --title "Minimal Kolibri Channel Test" --description "This is a minimal K +docker run --rm -it -v "$PWD/output:/output" local-kolibri2zim kolibri2zim --name "minimal_test" --title "Minimal Kolibri Channel Test" --description "This is a minimal K olibri Channel, with new Kolibri UI" --channel-id "7f744ce8d28b471eaf663abd60c92267" --zim-file "Minimal_Test.zim" ```