Fix NULL pointer dereference in zdb

ryao · behlendorf · commit aa822e4d9c0f · 2022-10-18T15:34:24.000-07:00
Clang's static analyzer complained that we dereference a NULL pointer in dump_path() if we return 0 when there is an error. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #14044
diff --git a/cmd/zdb/zdb.c b/cmd/zdb/zdb.c
@@ -3067,7 +3067,7 @@ open_objset(const char *path, const void *tag, objset_t **osp)
 	}
 	sa_os = *osp;
 
-	return (0);
+	return (err);
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -3067,7 +3067,7 @@ open_objset(const char path, const void tag, objset_t **osp)`
`3067`	`3067`	`}`
`3068`	`3068`	`sa_os = *osp;`
`3069`	`3069`
`3070`		`- return (0);`
	`3070`	`+ return (err);`
`3071`	`3071`	`}`
`3072`	`3072`
`3073`	`3073`	`static void`