[GPU] Fix kernel cache for loaded executables. #15998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the XLA kernel cache compatible with JAX module cache.
|
In the commit message, could you elaborate on what is the user-observable delta? (e.g. a sequence of steps X used to result in an undesirable state Y and now results in Z). You have that in tests, but it's a bit hard to connect this to what is user-observable (do we need a JAX test?) |
|
The failing JAX test was |
cheshire
approved these changes
Aug 15, 2024
| #include "xla/service/gpu/runtime/conditional_thunk.h" | ||
| #include "xla/service/gpu/runtime/sequential_thunk.h" | ||
| #include "xla/service/gpu/runtime/thunk.h" | ||
| #include "xla/service/gpu/runtime/while_thunk.h" |
There was a problem hiding this comment.
Should those cleanups be in this commit?
There was a problem hiding this comment.
It's tempting to include such trivial small cleanups while changing the files for other reasons (also because for us, external developers, submitting changes is a slower process). I'll try to separate them in the future.
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 15, 2024
Imported from GitHub PR openxla/xla#15998 LoadCache() has to be called also in GpuThunkAotCompilationResult::LoadExecutable() to properly initialize the state of the name uniquer in the IR emitter context on this path to execution. This makes the XLA kernel cache compatible with the JAX module cache (example test: `bazel test --test_env=XLA_FLAGS="--xla_gpu_enable_llvm_module_compilation_parallelism --xla_gpu_kernel_cache_file=/dev/shm/xla.kernel.cache" tests/compilation_cache_test_gpu`). Copybara import of the project: -- b51fbcac5c7f172d06eb9de79770564f2e2c1250 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix kernel cache for loaded executables. This makes the XLA kernel cache compatible with JAX module cache. Merging this change closes #15998 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15998 from openxla:fix_kernel_cache b51fbcac5c7f172d06eb9de79770564f2e2c1250 PiperOrigin-RevId: 663305969
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
Imported from GitHub PR #15998 LoadCache() has to be called also in GpuThunkAotCompilationResult::LoadExecutable() to properly initialize the state of the name uniquer in the IR emitter context on this path to execution. This makes the XLA kernel cache compatible with the JAX module cache (example test: `bazel test --test_env=XLA_FLAGS="--xla_gpu_enable_llvm_module_compilation_parallelism --xla_gpu_kernel_cache_file=/dev/shm/xla.kernel.cache" tests/compilation_cache_test_gpu`). Copybara import of the project: -- b51fbca by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix kernel cache for loaded executables. This makes the XLA kernel cache compatible with JAX module cache. Merging this change closes #15998 FUTURE_COPYBARA_INTEGRATE_REVIEW=#15998 from openxla:fix_kernel_cache b51fbca PiperOrigin-RevId: 663326327
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 16, 2024
Imported from GitHub PR openxla/xla#15998 LoadCache() has to be called also in GpuThunkAotCompilationResult::LoadExecutable() to properly initialize the state of the name uniquer in the IR emitter context on this path to execution. This makes the XLA kernel cache compatible with the JAX module cache (example test: `bazel test --test_env=XLA_FLAGS="--xla_gpu_enable_llvm_module_compilation_parallelism --xla_gpu_kernel_cache_file=/dev/shm/xla.kernel.cache" tests/compilation_cache_test_gpu`). Copybara import of the project: -- b51fbcac5c7f172d06eb9de79770564f2e2c1250 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix kernel cache for loaded executables. This makes the XLA kernel cache compatible with JAX module cache. Merging this change closes #15998 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15998 from openxla:fix_kernel_cache b51fbcac5c7f172d06eb9de79770564f2e2c1250 PiperOrigin-RevId: 663326327
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
Imported from GitHub PR #15998 LoadCache() has to be called also in GpuThunkAotCompilationResult::LoadExecutable() to properly initialize the state of the name uniquer in the IR emitter context on this path to execution. This makes the XLA kernel cache compatible with the JAX module cache (example test: `bazel test --test_env=XLA_FLAGS="--xla_gpu_enable_llvm_module_compilation_parallelism --xla_gpu_kernel_cache_file=/dev/shm/xla.kernel.cache" tests/compilation_cache_test_gpu`). Copybara import of the project: -- b51fbca by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix kernel cache for loaded executables. This makes the XLA kernel cache compatible with JAX module cache. Merging this change closes #15998 FUTURE_COPYBARA_INTEGRATE_REVIEW=#15998 from openxla:fix_kernel_cache b51fbca PiperOrigin-RevId: 663326327
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 16, 2024
Imported from GitHub PR openxla/xla#15998 LoadCache() has to be called also in GpuThunkAotCompilationResult::LoadExecutable() to properly initialize the state of the name uniquer in the IR emitter context on this path to execution. This makes the XLA kernel cache compatible with the JAX module cache (example test: `bazel test --test_env=XLA_FLAGS="--xla_gpu_enable_llvm_module_compilation_parallelism --xla_gpu_kernel_cache_file=/dev/shm/xla.kernel.cache" tests/compilation_cache_test_gpu`). Copybara import of the project: -- b51fbcac5c7f172d06eb9de79770564f2e2c1250 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix kernel cache for loaded executables. This makes the XLA kernel cache compatible with JAX module cache. Merging this change closes #15998 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15998 from openxla:fix_kernel_cache b51fbcac5c7f172d06eb9de79770564f2e2c1250 PiperOrigin-RevId: 663326327
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
Imported from GitHub PR #15998 LoadCache() has to be called also in GpuThunkAotCompilationResult::LoadExecutable() to properly initialize the state of the name uniquer in the IR emitter context on this path to execution. This makes the XLA kernel cache compatible with the JAX module cache (example test: `bazel test --test_env=XLA_FLAGS="--xla_gpu_enable_llvm_module_compilation_parallelism --xla_gpu_kernel_cache_file=/dev/shm/xla.kernel.cache" tests/compilation_cache_test_gpu`). Copybara import of the project: -- b51fbca by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix kernel cache for loaded executables. This makes the XLA kernel cache compatible with JAX module cache. Merging this change closes #15998 FUTURE_COPYBARA_INTEGRATE_REVIEW=#15998 from openxla:fix_kernel_cache b51fbca PiperOrigin-RevId: 663326327
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 16, 2024
Imported from GitHub PR openxla/xla#15998 LoadCache() has to be called also in GpuThunkAotCompilationResult::LoadExecutable() to properly initialize the state of the name uniquer in the IR emitter context on this path to execution. This makes the XLA kernel cache compatible with the JAX module cache (example test: `bazel test --test_env=XLA_FLAGS="--xla_gpu_enable_llvm_module_compilation_parallelism --xla_gpu_kernel_cache_file=/dev/shm/xla.kernel.cache" tests/compilation_cache_test_gpu`). Copybara import of the project: -- b51fbcac5c7f172d06eb9de79770564f2e2c1250 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix kernel cache for loaded executables. This makes the XLA kernel cache compatible with JAX module cache. Merging this change closes #15998 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15998 from openxla:fix_kernel_cache b51fbcac5c7f172d06eb9de79770564f2e2c1250 PiperOrigin-RevId: 663326327
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 16, 2024
Imported from GitHub PR #15998 LoadCache() has to be called also in GpuThunkAotCompilationResult::LoadExecutable() to properly initialize the state of the name uniquer in the IR emitter context on this path to execution. This makes the XLA kernel cache compatible with the JAX module cache (example test: `bazel test --test_env=XLA_FLAGS="--xla_gpu_enable_llvm_module_compilation_parallelism --xla_gpu_kernel_cache_file=/dev/shm/xla.kernel.cache" tests/compilation_cache_test_gpu`). Copybara import of the project: -- b51fbca by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix kernel cache for loaded executables. This makes the XLA kernel cache compatible with JAX module cache. Merging this change closes #15998 FUTURE_COPYBARA_INTEGRATE_REVIEW=#15998 from openxla:fix_kernel_cache b51fbca PiperOrigin-RevId: 663326327
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 16, 2024
Imported from GitHub PR openxla/xla#15998 LoadCache() has to be called also in GpuThunkAotCompilationResult::LoadExecutable() to properly initialize the state of the name uniquer in the IR emitter context on this path to execution. This makes the XLA kernel cache compatible with the JAX module cache (example test: `bazel test --test_env=XLA_FLAGS="--xla_gpu_enable_llvm_module_compilation_parallelism --xla_gpu_kernel_cache_file=/dev/shm/xla.kernel.cache" tests/compilation_cache_test_gpu`). Copybara import of the project: -- b51fbcac5c7f172d06eb9de79770564f2e2c1250 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix kernel cache for loaded executables. This makes the XLA kernel cache compatible with JAX module cache. Merging this change closes #15998 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15998 from openxla:fix_kernel_cache b51fbcac5c7f172d06eb9de79770564f2e2c1250 PiperOrigin-RevId: 663326327
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 16, 2024
…e only adds trivial dims. Reverts f8a3e0d FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15998 from openxla:fix_kernel_cache b51fbcac5c7f172d06eb9de79770564f2e2c1250 PiperOrigin-RevId: 663863020
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 16, 2024
…compilation Reverts f8a3e0d FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15998 from openxla:fix_kernel_cache b51fbcac5c7f172d06eb9de79770564f2e2c1250 PiperOrigin-RevId: 663525516
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 16, 2024
Reverts f8a3e0d FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15998 from openxla:fix_kernel_cache b51fbcac5c7f172d06eb9de79770564f2e2c1250 PiperOrigin-RevId: 663789692
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 16, 2024
Imported from GitHub PR openxla/xla#15998 LoadCache() has to be called also in GpuThunkAotCompilationResult::LoadExecutable() to properly initialize the state of the name uniquer in the IR emitter context on this path to execution. This makes the XLA kernel cache compatible with the JAX module cache (example test: `bazel test --test_env=XLA_FLAGS="--xla_gpu_enable_llvm_module_compilation_parallelism --xla_gpu_kernel_cache_file=/dev/shm/xla.kernel.cache" tests/compilation_cache_test_gpu`). Copybara import of the project: -- b51fbcac5c7f172d06eb9de79770564f2e2c1250 by Ilia Sergachev <isergachev@nvidia.com>: [GPU] Fix kernel cache for loaded executables. This makes the XLA kernel cache compatible with JAX module cache. Merging this change closes #15998 PiperOrigin-RevId: 663854304
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Aug 16, 2024
Reverts f8a3e0d FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15998 from openxla:fix_kernel_cache b51fbcac5c7f172d06eb9de79770564f2e2c1250 PiperOrigin-RevId: 663872672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadCache() has to be called also in GpuThunkAotCompilationResult::LoadExecutable() to properly initialize the state of the name uniquer in the IR emitter context on this path to execution.
This makes the XLA kernel cache compatible with the JAX module cache (example test:
bazel test --test_env=XLA_FLAGS="--xla_gpu_enable_llvm_module_compilation_parallelism --xla_gpu_kernel_cache_file=/dev/shm/xla.kernel.cache" tests/compilation_cache_test_gpu).