Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine implementation of HLO_SpeculatableIfAllInputsStatic #2186

Open
mlevesquedion opened this issue Apr 9, 2024 · 0 comments
Open

Refine implementation of HLO_SpeculatableIfAllInputsStatic #2186

mlevesquedion opened this issue Apr 9, 2024 · 0 comments
Labels

Comments

@mlevesquedion
Copy link
Contributor

The logic is a little bit too conservative currently:

func.func @xor(%dynamic_arg: tensor<?xi64>) {
  %speculatable = stablehlo.xor %dynamic_arg, %dynamic_arg : (tensor<?xi64>, tensor<?xi64>) -> tensor<?xi64>
}

Currently, we consider the above not speculatable, but actually because the operands are the same there cannot be a mismatch at runtime so this is speculatable.

@mlevesquedion mlevesquedion self-assigned this Apr 9, 2024
@GleasonK GleasonK moved this to Backlog in StableHLO v1.0 Release Apr 17, 2024
@mlevesquedion mlevesquedion removed their assignment Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants