Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more dynamic inputs to DynamicConvOp #1268

Open
gnecula opened this issue Mar 3, 2023 · 1 comment
Open

Add more dynamic inputs to DynamicConvOp #1268

gnecula opened this issue Mar 3, 2023 · 1 comment
Assignees
Labels

Comments

@gnecula
Copy link
Contributor

gnecula commented Mar 3, 2023

Request description

Currently DynamicConvOp supports computed padding. We will also need computed window_strides, lhs_dilation and rhs_dilation.

I also notice that the op takes padding both as an input and as an attribute. JAX does not use the padding attribute, but I thought I'd point this out in case it is a mistake.

@burmako burmako self-assigned this Mar 4, 2023
@burmako burmako changed the title Expand DynamicConvOp with more dynamic inputs Add more dynamic inputs to DynamicConvOp Mar 9, 2023
@burmako burmako moved this to In Progress in Frontend contract Apr 12, 2023
@burmako burmako moved this from In Progress to Todo in Frontend contract Apr 23, 2023
@gnecula
Copy link
Contributor Author

gnecula commented May 9, 2023

I noticed that JAX's batching rules will end up making batch_group_count and feature_group_count dynamic if some of the input dimensions are dynamic. Hence, we need dynamic support for these also.

@burmako burmako moved this from Todo to In Progress in Frontend contract Jun 3, 2023
@burmako burmako assigned GleasonK and unassigned burmako Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

4 participants