Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing padding from DynamicConvOp #1212

Open
burmako opened this issue Feb 26, 2023 · 0 comments
Open

Consider removing padding from DynamicConvOp #1212

burmako opened this issue Feb 26, 2023 · 0 comments
Assignees
@GleasonK
Labels
Dynamism

Comments

@burmako
Copy link
Contributor

burmako commented Feb 26, 2023

DynamicConvOp already has d_padding, so I don't think it needs padding. It has both at the moment because it shares ConvolutionAttributes with ConvolutionOp, which is an implementation detail that has unfortunately leaked into the API.
@burmako burmako added the Spec label Feb 26, 2023
@burmako burmako self-assigned this Mar 4, 2023
@burmako burmako added Dynamism and removed Spec labels Mar 4, 2023
@burmako burmako moved this to In Progress in Frontend contract Jun 3, 2023
@burmako burmako assigned GleasonK and unassigned burmako Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GleasonK GleasonK

Labels
Dynamism
Projects
Frontend contract
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burmako @GleasonK