Validate Postgres schema identifier length

Author: thomasjiangcy

packages/openworkflow/postgres/backend.test.ts

@@ -38,6 +38,14 @@ describe("BackendPostgres.connect errors", () => {
       }),
     ).rejects.toThrow(/Invalid schema name/);
   });
+
+  test("throws for schema names longer than 63 bytes", async () => {
+    await expect(
+      BackendPostgres.connect(DEFAULT_POSTGRES_URL, {
+        schema: "a".repeat(64),
+      }),
+    ).rejects.toThrow(/at most 63 bytes/i);
+  });
 });
 
 describe("BackendPostgres schema option", () => {

packages/openworkflow/postgres/postgres.test.ts

@@ -42,6 +42,10 @@ describe("postgres", () => {
     test("throws for invalid schema names", () => {
       expect(() => migrations("invalid-schema")).toThrow(/Invalid schema name/);
     });
+
+    test("throws for schema names longer than 63 bytes", () => {
+      expect(() => migrations("a".repeat(64))).toThrow(/at most 63 bytes/i);
+    });
   });
 
   describe("migrate()", () => {

packages/openworkflow/postgres/postgres.ts

@@ -10,6 +10,7 @@ export type Postgres = ReturnType<typeof postgres>;
 export type PostgresOptions = Parameters<typeof postgres>[1];
 
 const SCHEMA_NAME_PATTERN = /^[a-zA-Z_]\w*$/;
+const MAX_POSTGRES_IDENTIFIER_BYTES = 63;
 
 /**
  * newPostgres creates a new Postgres client.
@@ -273,6 +274,12 @@ export function assertValidSchemaName(schema: string): void {
       `Invalid schema name "${schema}". Use a Postgres identifier (letters, numbers, underscores; cannot start with a number).`,
     );
   }
+
+  if (Buffer.byteLength(schema, "utf8") > MAX_POSTGRES_IDENTIFIER_BYTES) {
+    throw new Error(
+      `Invalid schema name "${schema}". Postgres identifiers must be at most ${String(MAX_POSTGRES_IDENTIFIER_BYTES)} bytes.`,
+    );
+  }
 }
 
 /**