[fix] Organization matching query does not exist #238 #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashikajotwani12
force-pushed
the
issue-238-org-does-not-exit
branch
from
870c7c8 to
244c330
Compare
yashikajotwani12
changed the title
nemesifier
requested changes
Jun 10, 2022
openwisp_notifications/handlers.py
Outdated
| if created: | ||
| tasks.ns_organization_created.delay(instance.pk) | ||
| def notification_setting_org_created(instance, **kwargs): | ||
| transaction.on_commit(lambda: tasks.ns_organization_created.delay(instance.pk)) |
Member
There was a problem hiding this comment.
This logic must be executed only when an organization is created, otherwise it will be executed any time an organization is updated, which we do not want.
Suggested change
| transaction.on_commit(lambda: tasks.ns_organization_created.delay(instance.pk)) | |
| if created: | |
| transaction.on_commit(lambda: tasks.ns_organization_created.delay(instance.pk)) |
nemesifier
approved these changes
Jun 30, 2022
nemesifier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Update:
Fixes #238