Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compatibility with DRF 3.7 #146

Merged
merged 3 commits into from
Nov 2, 2017
Merged

Allow compatibility with DRF 3.7 #146

merged 3 commits into from
Nov 2, 2017

Conversation

pkolios
Copy link
Contributor

@pkolios pkolios commented Oct 18, 2017

No description provided.

@nemesifier
Copy link
Member

Hi @pkolios, thank you for contributing. It seems two tasks are failing with:

module 'django.contrib.postgres.fields' has no attribute 'JSONField'

Maybe DRF 3.7 dropped support for older versions of django?

@pkolios
Copy link
Contributor Author

pkolios commented Oct 18, 2017

True, it looks like it's django 1.10 and upwards. http://www.django-rest-framework.org/#requirements

encode/django-rest-framework#5457

How would you like to proceed?

@nemesifier
Copy link
Member

@pkolios let's remove support for django versions older than 1.9, we'll release this update as a new minor version (0.12.x as you already indicated in the README).

@pkolios
Copy link
Contributor Author

pkolios commented Oct 19, 2017

Cool, anything else left to do on this PR?

@auvipy
Copy link
Collaborator

auvipy commented Oct 25, 2017

this brings borth drf 3.7 and dj2.x compat #147

@auvipy auvipy merged commit 9e57496 into openwisp:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants