Restructure the warning handling for the LaTeXImage.pm module. #1329
+31
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
lateximage-warnings
branch
from
cbb2b71 to
454fa21
Compare
drgrice1
force-pushed
the
lateximage-warnings
branch
2 times, most recently
from
8c9f1ff to
092afff
Compare
This moves the error warnings up to immediately after latex or pdflatex/xelatex (whichever is the latex2pdf program) runs. This way these errors are always warned. When the `TikZ.pm` module was converted the the `LaTeXImage.pm` module and restructured for PTX output, it resulted in the case that a `pdf` file is the end result (such as for hardcopy) not having these warnings issued. This is to address issue openwebwork/webwork2#2834.
drgrice1
force-pushed
the
lateximage-warnings
branch
from
092afff to
8e09356
Compare
dlglin
approved these changes
Dec 2, 2025
Member
dlglin
left a comment
dlglin
left a comment
There was a problem hiding this comment.
This now gives the full latex output when using "download hardcopy" in the problem editor, which I guess is the desired result (though it's a lot to read through).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the error warnings up to immediately after latex or pdflatex/xelatex (whichever is the latex2pdf program) runs. This way these errors are always warned.
When the
TikZ.pmmodule was converted the theLaTeXImage.pmmodule and restructured for PTX output, it resulted in the case that apdffile is the end result (such as for hardcopy) not having these warnings issued.This is to address issue openwebwork/webwork2#2834.