Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass routing prop to agent.oob.receiveInvitation() #1376

Closed
jimezesinachi opened this issue Mar 8, 2023 · 1 comment · Fixed by #1511
Closed

Add ability to pass routing prop to agent.oob.receiveInvitation() #1376

jimezesinachi opened this issue Mar 8, 2023 · 1 comment · Fixed by #1511

Comments

@jimezesinachi
Copy link
Contributor

jimezesinachi commented Mar 8, 2023

When an agent accepts a proof request, the ProofsApi automatically sets up mediation for the presentation message it sends back to the verifier (requester), due to this code in the Proofs API: https://github.com/hyperledger/aries-framework-javascript/blob/main/packages/core/src/modules/proofs/ProofsApi.ts. It doesn't call getRouting with useDefaultMediator: false. This means it will fail if no internet is present, and it will also fail with the return routing response.

When receiving an OOB invitation, we want to be able to pass an optional routing prop along with the invitation. This routing prop is only used when creating a connection. If we can somehow store this routing, we could use it instead of creating new routing in the ProofsApi acceptRequest method.

This issue is related to #1250.

@TimoGlastra
Copy link
Contributor

Routing already supported, but it wasn't being used for connection-less exchanges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants