Skip to content

Conversation

@dbluhm
Copy link
Contributor

@dbluhm dbluhm commented Sep 24, 2024

Opening early.

This PR moves ICv1 and PPv1 to a plugin.

This description will be updated with notes on any sharp edges encountered.

Plugin-ification

ICv1

  • Credential revocation state used to get updated by the revocation manager by using the exchange record directly. Changed to trigger an event instead.

PPv1

  • OOB depends on recalling pres ex records to populate attachments.
  • Pres Exch handler depends on recalling pres ex records to retrieve proof request.

Features Lost

ICv1

  • Attaching a credential offer to an OOB invitation. See this comment for thoughts on how to address this, if needed.

PPv1

  • Attaching a presentation request to an OOB invitation. See this comment for thoughts on how to address this, if needed.

Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@dbluhm dbluhm changed the title feat: copy over icv1 and ppv1 Issue Credential v1 and Present Proof v1 Sep 24, 2024
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@jamshale
Copy link
Contributor

This has become quite out of date with aca-py. It would still be a nice thing to accomplish but I'm going to close this. It will be another PR if it gets accomplished.

@jamshale jamshale closed this Sep 26, 2025
@jamshale jamshale added stale Has become stale but still has valuable work reference-for-future-work labels Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reference-for-future-work stale Has become stale but still has valuable work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants