Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try untying bitslice from internal mask #4877

Open
magnumripper opened this issue Nov 18, 2021 · 0 comments
Open

Try untying bitslice from internal mask #4877

magnumripper opened this issue Nov 18, 2021 · 0 comments

Comments

@magnumripper
Copy link
Member

magnumripper commented Nov 18, 2021

@solardiz in #4871 (comment):
(...) apparently when running with a mask, the bit depths are filled using the mask multiplier. This probably means we have efficiency loss when the mask multiplier isn't a multiple of 32 (which it usually isn't). For example, for the 676 seen in our default benchmark mask, the actual number of hashes computed is probably 704, and if so 28 hash computations or almost 4% of total are wasted. I didn't verify this and don't recall past discussions of it - but it's the only plausible explanation I have of what I saw in @sayan1an's host code. Despite of this wastage, it might be the most efficient way to implement mask in there (considering locality of reference).

I think we should try doing this differently, and see where it leads.

Perhaps as a first step though, search through the ML from back in 2015 or so when Sayantan wrote the code - maybe he already established that the current way of doing it is the best way? I find it hard to believe though.

@magnumripper magnumripper changed the title Try untying bitslice width from internal mask Try untying bitslice from internal mask Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant