Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work or documentation changes needed for rule eX and e?C #3708

Open
jfoug opened this issue Mar 28, 2019 · 0 comments
Open

work or documentation changes needed for rule eX and e?C #3708

jfoug opened this issue Mar 28, 2019 · 0 comments
Labels
documentation notes/external issues portability regression Bug introduced with certain change(s), causing performance degradation or feature loss

Comments

@jfoug
Copy link
Collaborator

jfoug commented Mar 28, 2019

This follows along with hashcat/hashcat#1970

Right now, there is some ambiguity on things, which have caused the 2 projects to return different values for the eX rule (HC does not have the e?C rule as it does not do classes).

At a minimum, we should document FULLY exactly how these rules work. We may need to change some code in rules, IF the user base expects certain behaviors.

FOR NOW, lets hold off on this, and see just where the logic is expected to go. Once that is finalized, then we can document EXACTLY what is to be expected, and if there are any changes needed to the rules.c, make them. It should hopefully be trivial changes. The CLASS macro suite has the framework done. We just have to get the 'true' and 'false' parts being passed into the macro working the way people expect the logic to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation notes/external issues portability regression Bug introduced with certain change(s), causing performance degradation or feature loss
Projects
None yet
Development

No branches or pull requests

1 participant