Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to get closer to Jumbo-2 #1879

Closed
2 tasks
magnumripper opened this issue Nov 12, 2015 · 25 comments
Closed
2 tasks

Try to get closer to Jumbo-2 #1879

magnumripper opened this issue Nov 12, 2015 · 25 comments

Comments

@magnumripper
Copy link
Member

magnumripper commented Nov 12, 2015

Here's current blockers for a Jumbo-2. Tick off, or add to, this list as needed.


Here's all current bugs
Here's everything marked with Jumbo-2 milestone

@magnumripper magnumripper added this to the 1.8.0-jumbo-2 milestone Nov 12, 2015
@magnumripper
Copy link
Member Author

Several of the blockers are depending on @Sayantan2048. I've tried to address them but I don't seem to get anywhere.

@jfoug
Copy link
Collaborator

jfoug commented Nov 12, 2015

#1428 ?
#1289 ?
#1199 Checked in. I have had mine this way for months. It runs better on all my AVX/AVX2 systems. 1468537
#570 ?

Should we change the other jumbo-2 to jumbo-3 ?

@magnumripper
Copy link
Member Author

Those you list (and some others) should be fixed if possible but are definitely not blockers. They can be tagged J2 for now but may change to J3.

I did change a number of enhancements/new-formats to J3 milestone (or no milestone).

@magnumripper
Copy link
Member Author

BTW I don't care much about JP problems if Solar doesn't bother fixing them. When we're done with our blockers and some more testing, we can suggest to Solar we're ready for a release and he may consider fixing #1199 and others while at it.

(JP is what I suggest we call "John Proper" aka "non Jumbo" from now on - "core" is better used for core code as in cracker.c and loader.c - basically anything but formats)

@jfoug
Copy link
Collaborator

jfoug commented Nov 12, 2015

That was my reason for including #1199. how about JPr ? :) Or even JB (john base)

There may be a few other that are 'CORE' issues which we should look at possibly. The rules crash, I do have a fix (workaround) for

@magnumripper
Copy link
Member Author

Someone (was it me??) apparently added non-blockers like #883 to the list. I'll let them stand for now, it would be awesome to get all of them fixed but they are definitely not blocking a release of Jumbo 2.

@jfoug
Copy link
Collaborator

jfoug commented Nov 27, 2015

I added everything to this list which was marked as J2. I know you removed a bunch, but someone else re-marked them. If they are in the search for J2, they are also on this list.

@magnumripper
Copy link
Member Author

I added everything to this list which was marked as J2

That's just weird and 100% redundant. You'd obviously use this link instead which doesn't need manual updates. I wanted to establish a list of blockers. Fixing things like #883 is not important - if it's not fixed we'll just move it to J3. Same goes for many others.

@magnumripper
Copy link
Member Author

I dropped the non-blockers from the list.

@jfoug
Copy link
Collaborator

jfoug commented Oct 31, 2016

bump!! jumbo 1 is REALLY getting dated, and is what is in all the distro's that install john.

@magnumripper
Copy link
Member Author

magnumripper commented Nov 21, 2016

@jfoug
Copy link
Collaborator

jfoug commented Nov 21, 2016

Many of those 'bugs' are far from show stoppers.

@magnumripper
Copy link
Member Author

Sure, but most of them should definitely be fixed before a release.

@kholia
Copy link
Member

kholia commented Mar 8, 2017

If we want to make this release, I think we have to drop some "blocker" bugs from this issue.

For example, #1746 doesn't look like a blocker bug to me. #1908 is about performance, doesn't sounds like a blocker.

@kholia
Copy link
Member

kholia commented Mar 8, 2017

@Sayantan2048 seems gone for a while. We have a workaround for #1782 which works fine, so it doesn't sound like a blocker.

@magnumripper
Copy link
Member Author

I really think #1746 should be fixed, but in a pinch we could just document it as "some combinations simply won't work right now - but they will fail self-test".

I removed the milestone from #1782 and #1908.

@magnumripper
Copy link
Member Author

I dropped #1938 as well, it's just a variant of #1782.

@claudioandre-br
Copy link
Member

There is another critical bug that needs attention: the --restore bug.

  • it misses candidates (oh, it is a bad bug).

@magnumripper
Copy link
Member Author

magnumripper commented Mar 8, 2017

Yeah I was just going to add that we need lots and lots of soft-stop/restore (press q) and hard-stop/restore (kill -9) testing after all changes @jfoug did to resuming. I've found and fixed bugs since that and I suspect there are more. That "restore tester format" doesn't seem very good since he actually introduced bugs when using it 😢

@claudioandre-br
Copy link
Member

I know @solardiz and @magnumripper are busy people, but we are seeing "messages", the Fedora 23 issue I just post (no link on purpose) is only the latest, suggest that people might became confused and disappointed about JtR maintenance status.

@solardiz
Copy link
Member

solardiz commented Nov 1, 2017

We definitely ought to make a new numbered release soon. I'd appreciate it if you folks get jumbo closer to that state. From my side, I intend to release 1.8.1, in part so that jumbo's version number differs from the previous one at least this little bit more. ;-) So let's plan to release a 1.8.1-jumbo-1 soon - perhaps in two months?

@magnumripper
Copy link
Member Author

We have a really nasty blocker in #2817 now. I wish Jim could come back to us for a while again...

@jfoug
Copy link
Collaborator

jfoug commented Nov 3, 2017

I will be around some shortly, and will look into #2817 I am actually retiring from tech at the end of the year, and moving towards more peace in my life. I am just tired of the corp rat race.

@kholia
Copy link
Member

kholia commented Nov 3, 2017

@jfoug Having you back would be awesome. I tried hacking on the dynamic compiler recently but didn't find a good solution for the problem I was trying to solve.

@magnumripper
Copy link
Member Author

magnumripper commented Dec 15, 2018

Closing this in favor of a new #3513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants