【Hackathon 5th No.97】add paddle tanh_shrink op #20067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: build
Asthestarsfalll
changed the title
Asthestarsfalll
changed the title
Asthestarsfalll
changed the title
|
@yuxu42 Could you help to have a review on this PR, thanks |
|
@xczhai Could you please help review? Thanks! |
xczhai
reviewed
Nov 6, 2023
| data = np.random.uniform(-10, 20, [4, 3, 2]).astype(np.float32) | ||
| tanh_shrink("tanh_shrink_2", data) | ||
|
|
||
| # data = np.random.uniform(10, 20, [2, 3, 4]).astype(np.float16) // only on gpu |
There was a problem hiding this comment.
please remove the useless codes if unnecessary.
|
@Asthestarsfalll please rebase the PR. triger the CI again. Thanks. |
yuxu42
added
PaddlePaddle Hackathon
|
@ceciliapeng2011 Hi Cecilia, could you help merge the PR? Thanks. |
ceciliapeng2011
approved these changes
Nov 22, 2023
|
@Asthestarsfalll could you rebase and fix the CI issue? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
add paddle tanh_shrink op
Tickets:
waitting for
Reference:
Docs: https://www.paddlepaddle.org.cn/documentation/docs/zh/api/paddle/nn/functional/tanhshrink_cn.html#tanhshrink
Support data type:
UnitTest: https://github.com/PaddlePaddle/Paddle/blob/29059a349810a7cb895d84b90f1b177fed952791/test/legacy_test/test_activation_op.py#L1094
Code: https://github.com/PaddlePaddle/Paddle/blob/release/2.5/python/paddle/nn/functional/activation.py#L1404
PaddlePaddle/Paddle#57262
Test
waiting for: