[ARM CPU] Add ACL deconvolution operation #18655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add api update new update update tests update comments update
allnes
added
category: CPU
…into an/exp_deconv_1
…into an/exp_deconv_1
…into an/exp_deconv_1
alvoron
reviewed
Jul 25, 2023
| static bool customIsSupported(const DeconvAttrs& deconvAttrs, | ||
| const std::vector<MemoryDescPtr>& srcDescs, | ||
| const std::vector<MemoryDescPtr>& dstDescs) { | ||
| if (srcDescs[0]->getShape().getDims().size() != 4 || |
There was a problem hiding this comment.
ACL says input could be 3D or 4D and output precision should be exact as input one.
| } | ||
|
|
||
| private: | ||
| static bool validate_deconvolution_output_dimensions(unsigned int in_width, unsigned int in_height, |
There was a problem hiding this comment.
looks like this method is copied from ACL.
Shouldn't we rely on NEDeconvolutionLayer::validate? I assume it makes the same checks as well.
…into an/exp_deconv_1
…into an/exp_deconv_1
dmitry-gorokhov
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.