Skip to content

aiohttp migration fixes #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2025
Merged

aiohttp migration fixes #117

merged 5 commits into from
Jun 7, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 7, 2025

  • We should let the exception raise up as that is what downstream expects
  • Make sure we properly cleanup the connector/session
  • fixed close property to work for aiohttp

We should let the exception raise up as that is what downstream expects
Copy link

codecov bot commented Jun 7, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
onvif/client.py 50.00% 2 Missing ⚠️
onvif/managers.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
onvif/zeep_aiohttp.py 97.84% <ø> (+1.84%) ⬆️
onvif/managers.py 32.27% <0.00%> (ø)
onvif/client.py 65.66% <50.00%> (-0.36%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco bdraco changed the title Fix exception from get and post requests aiohttp migration fixes Jun 7, 2025
@bdraco bdraco merged commit 7c9d206 into async Jun 7, 2025
5 of 6 checks passed
@bdraco bdraco deleted the no_re_raise branch June 7, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant