Skip to content

Migrate to using aiohttp #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 7, 2025
Merged

Migrate to using aiohttp #115

merged 21 commits into from
Jun 7, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 7, 2025

Should fix most cases of home-assistant/core#120506 but not the cameras with broken firmware

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

Attention: Patch coverage is 94.19355% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
onvif/client.py 88.88% 4 Missing ⚠️
onvif/zeep_aiohttp.py 96.00% 4 Missing ⚠️
onvif/managers.py 83.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
onvif/util.py 76.66% <100.00%> (+1.66%) ⬆️
onvif/wrappers.py 65.21% <100.00%> (-1.45%) ⬇️
onvif/managers.py 32.27% <83.33%> (-0.43%) ⬇️
onvif/client.py 66.02% <88.88%> (+11.58%) ⬆️
onvif/zeep_aiohttp.py 96.00% <96.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco
Copy link
Member Author

bdraco commented Jun 7, 2025

Tested with a few cameras and home-assistant/core#146297
Lets do it

@bdraco bdraco marked this pull request as ready for review June 7, 2025 16:15
@bdraco bdraco merged commit 4dc87bd into async Jun 7, 2025
6 checks passed
@bdraco bdraco deleted the aiohttp branch June 7, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant