Fix pre-commit config (#55)

* Fix pre-commit config

The pre-commit config was inherited from xbox and needed
to be brought up to date

* comment out mypy since it currently fails

Author: bdraco

.pre-commit-config.yaml

@@ -1,47 +1,43 @@
+# See https://pre-commit.com for more information
+# See https://pre-commit.com/hooks.html for more hooks
+exclude: "CHANGELOG.md|.copier-answers.yml|.all-contributorsrc"
+default_stages: [pre-commit]
+
+ci:
+  autofix_commit_msg: "chore(pre-commit.ci): auto fixes"
+  autoupdate_commit_msg: "chore(pre-commit.ci): pre-commit autoupdate"
+
 repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v5.0.0
+    hooks:
+      - id: debug-statements
+      - id: check-builtin-literals
+      - id: check-case-conflict
+      - id: check-docstring-first
+      - id: check-toml
+      - id: check-xml
+      - id: detect-private-key
+      - id: end-of-file-fixer
+      - id: trailing-whitespace
+  - repo: https://github.com/pre-commit/mirrors-prettier
+    rev: v4.0.0-alpha.8
+    hooks:
+      - id: prettier
+        args: ["--tab-width", "2"]
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.8.0
+    hooks:
+      - id: ruff
+        args: [--fix, --exit-non-zero-on-fix]
+      - id: ruff-format
   - repo: https://github.com/asottile/pyupgrade
     rev: v2.7.2
     hooks:
       - id: pyupgrade
         args: [--py36-plus]
-  - repo: https://github.com/psf/black
-    rev: 20.8b1
-    hooks:
-      - id: black
-        args:
-          - --safe
-          - --quiet
-        files: ^((xbox|tests)/.+)?[^/]+\.py$
-  - repo: https://gitlab.com/pycqa/flake8
-    rev: 3.8.3
-    hooks:
-      - id: flake8
-        additional_dependencies:
-          # - flake8-docstrings==1.5.0
-          - pydocstyle==5.1.1
-        files: ^(xbox)/.+\.py$
-  - repo: https://github.com/PyCQA/bandit
-    rev: 1.6.2
-    hooks:
-      - id: bandit
-        args:
-          - --quiet
-          - --format=custom
-          - --configfile=bandit.yaml
-        files: ^(xbox|tests)/.+\.py$
-  - repo: https://github.com/PyCQA/isort
-    rev: 5.5.3
-    hooks:
-      - id: isort
-  - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v3.2.0
-    hooks:
-      - id: check-executables-have-shebangs
-        stages: [manual]
-      - id: check-json
-  - repo: https://github.com/prettier/prettier
-    rev: 2.0.4
-    hooks:
-      - id: prettier
-        stages: [manual]
-  
+#  - repo: https://github.com/pre-commit/mirrors-mypy
+#    rev: v1.11.2
+#    hooks:
+#      - id: mypy
+#        additional_dependencies: []

LICENSE

@@ -19,4 +19,3 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.
-

examples/events.py

@@ -1,10 +1,9 @@
 """Example to fetch pullpoint events."""
+
 import asyncio
 import datetime as dt
 import logging
 
-from pytz import UTC
-from zeep import xsd
 
 from onvif import ONVIFCamera
 

examples/rotate_image.py

@@ -4,7 +4,7 @@
 
 
 async def rotate_image_180():
-    """ Rotate the image """
+    """Rotate the image"""
 
     # Create the media service
     mycam = ONVIFCamera("192.168.0.112", 80, "admin", "12345")
@@ -14,7 +14,7 @@ async def rotate_image_180():
     profiles = await media_service.GetProfiles()
 
     # Use the first profile and Profiles have at least one
-    token = profiles[0].token
+    token = profiles[0].token  # noqa: F841
 
     # Get all video source configurations
     configurations_list = await media_service.GetVideoSourceConfigurations()

onvif/__init__.py

@@ -1,4 +1,5 @@
 """Initialize onvif."""
+
 import zeep
 
 from onvif.client import SERVICES, ONVIFCamera, ONVIFService

onvif/client.py

@@ -1,4 +1,5 @@
 """ONVIF Client."""
+
 from __future__ import annotations
 
 import asyncio

onvif/exceptions.py

@@ -1,4 +1,4 @@
-""" Core exceptions raised by the ONVIF Client """
+"""Core exceptions raised by the ONVIF Client"""
 
 # Error codes setting
 # Error unknown, e.g, HTTP errors

onvif/managers.py

@@ -1,4 +1,5 @@
 """ONVIF Managers."""
+
 from __future__ import annotations
 
 from abc import abstractmethod
@@ -227,9 +228,9 @@ async def _start(self) -> float:
             }
         )
         # pylint: disable=protected-access
-        device.xaddrs[
-            "http://www.onvif.org/ver10/events/wsdl/NotificationConsumer"
-        ] = normalize_url(result.SubscriptionReference.Address._value_1)
+        device.xaddrs["http://www.onvif.org/ver10/events/wsdl/NotificationConsumer"] = (
+            normalize_url(result.SubscriptionReference.Address._value_1)
+        )
         # Create subscription manager
         # 5.2.3 BASIC NOTIFICATION INTERFACE - NOTIFY
         # Call SetSynchronizationPoint to generate a notification message

onvif/transport.py

@@ -1,4 +1,5 @@
 """ONVIF transport."""
+
 from __future__ import annotations
 
 import os.path

onvif/types.py

@@ -1,6 +1,5 @@
 """ONVIF types."""
 
-
 import ciso8601
 from zeep.xsd.types.builtins import DateTime, treat_whitespace