Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saving PIN for lock/unlock #148

Open
breed opened this issue Jan 16, 2023 · 3 comments
Open

saving PIN for lock/unlock #148

breed opened this issue Jan 16, 2023 · 3 comments

Comments

@breed
Copy link

breed commented Jan 16, 2023

for the tesla roadster, it would be nice if the PIN could be saved in settings so that you don't get prompted every time.

i would guess the PIN would be added as one of the Parameters in the setup. right?

@markwj
Copy link
Member

markwj commented Jan 17, 2023

I would be concerned about this from a security point of view (especially on North American roadsters without the immobiliser). The PIN acts as a dual factor, as it is not stored anywhere. If we store it in the App / Car Module then that seems problematic.

@breed
Copy link
Author

breed commented Jan 17, 2023

the pin is such a weak factor. it is easily bruteforceable. it would still be protected by the phone security. if people want to be prompted everytime for the PIN, they could leave it unset.

@Picard0147
Copy link

Picard0147 commented Jan 9, 2024

Saving pin in app mean that no one can see me when i punchin it in, so when phone is secure (no malware loaded) then it could be safer than being forced to enter pin every time i want to use pin protected funtion.
Moreover saving pin could be step toward one nice to have feature - biometric protected Lock/Unlock widgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants