Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Split up core module #57

Closed
ComradeVanti opened this issue Nov 1, 2023 · 2 comments
Closed

Discussion: Split up core module #57

ComradeVanti opened this issue Nov 1, 2023 · 2 comments

Comments

@ComradeVanti
Copy link
Collaborator

ComradeVanti commented Nov 1, 2023

The core.ts module is pretty big and contains a variety of different common functionality. I would propose splitting this module into multiple smaller ones dedicated to specific data-types or workflows.

This way related code is kept together which makes it easier to find it.

This does not introduce any new functionality, but hopefully makes it easier to add new stuff in the future.

While converting the project to typescript I already did this for some functions such as splitPkgName which moved from core to a module for all functions related to package-names.

Thoughts?

@favoyang
Copy link
Member

favoyang commented Nov 1, 2023

Sounds good to me.

@ComradeVanti
Copy link
Collaborator Author

Alright, working on this here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants