Skip to content

Commit 4a7f142

Browse files
committed
fuse: fine-grained request ftraces
Rename trace_fuse_request_send to trace_fuse_request_enqueue Add trace_fuse_request_send Add trace_fuse_request_bg_enqueue Add trace_fuse_request_enqueue This helps to track entire request time and time in different queues. Signed-off-by: Bernd Schubert <bschubert@ddn.com>
1 parent 9efaa8d commit 4a7f142

File tree

3 files changed

+46
-14
lines changed

3 files changed

+46
-14
lines changed

fs/fuse/dev.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,9 @@ static void fuse_send_one(struct fuse_iqueue *fiq, struct fuse_req *req)
261261
req->in.h.len = sizeof(struct fuse_in_header) +
262262
fuse_len_args(req->args->in_numargs,
263263
(struct fuse_arg *) req->args->in_args);
264-
trace_fuse_request_send(req);
264+
265+
/* enqueue, as it is send to "fiq->ops queue" */
266+
trace_fuse_request_enqueue(req);
265267
fiq->ops->send_req(fiq, req);
266268
}
267269

@@ -568,6 +570,8 @@ static int fuse_request_queue_background(struct fuse_req *req)
568570
}
569571
__set_bit(FR_ISREPLY, &req->flags);
570572

573+
trace_fuse_request_bg_enqueue(req);
574+
571575
#ifdef CONFIG_FUSE_IO_URING
572576
if (fuse_uring_ready(fc))
573577
return fuse_request_queue_background_uring(fc, req);
@@ -1286,6 +1290,7 @@ static ssize_t fuse_dev_do_read(struct fuse_dev *fud, struct file *file,
12861290
clear_bit(FR_PENDING, &req->flags);
12871291
list_del_init(&req->list);
12881292
spin_unlock(&fiq->lock);
1293+
trace_fuse_request_send(req);
12891294

12901295
args = req->args;
12911296
reqsize = req->in.h.len;

fs/fuse/dev_uring.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#include "fuse_i.h"
88
#include "dev_uring_i.h"
99
#include "fuse_dev_i.h"
10+
#include "fuse_trace.h"
1011

1112
#include <linux/fs.h>
1213
#include <linux/io_uring/cmd.h>
@@ -692,6 +693,7 @@ static void fuse_uring_send(struct fuse_ring_ent *ent, struct io_uring_cmd *cmd,
692693
ent->cmd = NULL;
693694
spin_unlock(&queue->lock);
694695

696+
trace_fuse_request_send(ent->fuse_req);
695697
io_uring_cmd_done(cmd, ret, 0, issue_flags);
696698
}
697699

fs/fuse/fuse_trace.h

Lines changed: 38 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -77,30 +77,55 @@ OPCODES
7777
#define EM(a, b) {a, b},
7878
#define EMe(a, b) {a, b}
7979

80-
TRACE_EVENT(fuse_request_send,
80+
#define FUSE_REQ_TRACE_FIELDS \
81+
__field(dev_t, connection) \
82+
__field(uint64_t, unique) \
83+
__field(enum fuse_opcode, opcode) \
84+
__field(uint32_t, len) \
85+
86+
#define FUSE_REQ_TRACE_ASSIGN(req) \
87+
do { \
88+
__entry->connection = req->fm->fc->dev; \
89+
__entry->unique = req->in.h.unique; \
90+
__entry->opcode = req->in.h.opcode; \
91+
__entry->len = req->in.h.len; \
92+
} while (0)
93+
94+
95+
TRACE_EVENT(fuse_request_enqueue,
8196
TP_PROTO(const struct fuse_req *req),
97+
TP_ARGS(req),
98+
TP_STRUCT__entry(FUSE_REQ_TRACE_FIELDS),
99+
TP_fast_assign(FUSE_REQ_TRACE_ASSIGN(req)),
82100

101+
TP_printk("connection %u req %llu opcode %u (%s) len %u ",
102+
__entry->connection, __entry->unique, __entry->opcode,
103+
__print_symbolic(__entry->opcode, OPCODES), __entry->len)
104+
);
105+
106+
TRACE_EVENT(fuse_request_bg_enqueue,
107+
TP_PROTO(const struct fuse_req *req),
83108
TP_ARGS(req),
109+
TP_STRUCT__entry(FUSE_REQ_TRACE_FIELDS),
110+
TP_fast_assign(FUSE_REQ_TRACE_ASSIGN(req)),
84111

85-
TP_STRUCT__entry(
86-
__field(dev_t, connection)
87-
__field(uint64_t, unique)
88-
__field(enum fuse_opcode, opcode)
89-
__field(uint32_t, len)
90-
),
112+
TP_printk("connection %u req %llu opcode %u (%s) len %u ",
113+
__entry->connection, __entry->unique, __entry->opcode,
114+
__print_symbolic(__entry->opcode, OPCODES), __entry->len)
115+
);
91116

92-
TP_fast_assign(
93-
__entry->connection = req->fm->fc->dev;
94-
__entry->unique = req->in.h.unique;
95-
__entry->opcode = req->in.h.opcode;
96-
__entry->len = req->in.h.len;
97-
),
117+
TRACE_EVENT(fuse_request_send,
118+
TP_PROTO(const struct fuse_req *req),
119+
TP_ARGS(req),
120+
TP_STRUCT__entry(FUSE_REQ_TRACE_FIELDS),
121+
TP_fast_assign(FUSE_REQ_TRACE_ASSIGN(req)),
98122

99123
TP_printk("connection %u req %llu opcode %u (%s) len %u ",
100124
__entry->connection, __entry->unique, __entry->opcode,
101125
__print_symbolic(__entry->opcode, OPCODES), __entry->len)
102126
);
103127

128+
104129
TRACE_EVENT(fuse_request_end,
105130
TP_PROTO(const struct fuse_req *req),
106131

0 commit comments

Comments
 (0)