Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL for <input type=file> #174

Closed
mrmckeb opened this issue Sep 13, 2020 · 4 comments
Closed

RTL for <input type=file> #174

mrmckeb opened this issue Sep 13, 2020 · 4 comments
Labels

Comments

@mrmckeb
Copy link
Collaborator

mrmckeb commented Sep 13, 2020

This issue comes from this comment: #140 (comment)

A common convention for RTL languages is to reverse the label and button position - where the label is now first, and the button second.

Feature Chrome Firefox Safari
RTL reversed

The table below assesses the libraries and websites discussed in #114. Where libraries are marked as N/A, they didn't use the standard button-label layout.

Feature MOJ GitHub Ant Design Carbon Evergreen Materialise Bootstrap
RTL reversed N/A N/A N/A

Based on this research, I propose that we move forward with the recommendation that when the label is positioned to the right of the button, this is reversed for RTL languages.

@una
Copy link
Collaborator

una commented Sep 16, 2020

This is a great point. We should add RTL views/support to all elements (see also: checkbox, radio, select, color input, calendar etc.)

cc @gregwhitworth

@gregwhitworth
Copy link
Member

RTL gets into style IMO as it's the implications of writing-mode which should handle text and layout. I don't think this currently belongs in an Open UI specification.

@gregwhitworth gregwhitworth added the agenda+ Use this label if you'd like the topic to be added to the meeting agenda label Sep 22, 2020
@gregwhitworth gregwhitworth removed the agenda+ Use this label if you'd like the topic to be added to the meeting agenda label Dec 8, 2020
@github-actions
Copy link

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label Mar 20, 2022
@andrico1234
Copy link
Collaborator

andrico1234 commented Mar 26, 2022

Closing due to inactivity, and Greg's following comment:

RTL gets into style IMO as it's the implications of writing-mode which should handle text and layout. I don't think this currently belongs in an Open UI specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants