Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

It doesn't reconnect when changing the sessionId props in OTSession #18

Closed
ggarber opened this issue May 30, 2017 · 2 comments
Closed

It doesn't reconnect when changing the sessionId props in OTSession #18

ggarber opened this issue May 30, 2017 · 2 comments
Labels
bug

Comments

@ggarber
Copy link

ggarber commented May 30, 2017

It doesn't connect to a new session when rendering with new props because the connection logic is implemented in componentWillMount/componentWillUnmount.
@aiham
Copy link
Contributor

aiham commented May 30, 2017

Thanks @ggarber, I'll investigate this.

@aiham aiham added the bug label May 30, 2017
This was referenced May 31, 2017
Merged
Merged
@aiham aiham closed this as completed in #20 May 31, 2017
@aiham
Copy link
Contributor

aiham commented May 31, 2017

@ggarber Fix published to npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggarber @aiham