Skip to content

fix: gold pouch and manage issues #3779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kasajames wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: gold pouch and manage issues #3779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
835565a
Update game.cpp
kasajames Nov 28, 2025
bb92309
Update player.cpp
kasajames Nov 28, 2025
7497025
Update game.cpp
kasajames Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/creatures/players/player.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1546,6 +1546,9 @@ std::shared_ptr<Container> Player::getManagedContainer(ObjectCategory_t category
std::shared_ptr<Container> container = nullptr;
if (it != m_managedContainers.end()) {
container = isLootContainer ? it->second.first : it->second.second;
if (!isLootContainer && !container) {
container = it->second.first;
}
}

if (!container && category != OBJECTCATEGORY_DEFAULT) {
Expand Down
7 changes: 1 addition & 6 deletions src/game/game.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3220,7 +3220,7 @@ ReturnValue Game::internalCollectManagedItems(const std::shared_ptr<Player> &pla
}
}

if (!player->quickLootListItemIds.empty()) {
if (isLootContainer && !player->quickLootListItemIds.empty()) {
uint16_t itemId = item->getID();
bool isInList = std::ranges::find(player->quickLootListItemIds, itemId) != player->quickLootListItemIds.end();
if (player->quickLootFilter == QuickLootFilter_t::QUICKLOOTFILTER_ACCEPTEDLOOT && !isInList) {
Expand Down Expand Up @@ -5804,11 +5804,6 @@ void Game::playerSetManagedContainer(uint32_t playerId, ObjectCategory_t categor
return;
}

if (container->getID() == ITEM_GOLD_POUCH && !isLootContainer) {
player->sendTextMessage(MESSAGE_FAILURE, "You can only set the gold pouch as a loot container.");
return;
}

if (container->getHoldingPlayer() != player) {
player->sendCancelMessage("You must be holding the container to set it as a loot container.");
return;
Expand Down
Loading