Integrate Free Quests system CPP and refactor quest handling #3732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beats-dh
force-pushed
the
beats-fix-and-freeQuestCPP
branch
from
0a90c20 to
9e02501
Compare
|
Member
|
This change isn't beneficial because it moves a component that was previously bound to the global pack to something loaded across the entire server, even though it's only needed by the global pack. This increases compilation time, distributes unused code across all scenarios, and makes maintenance and review more difficult, without any apparent benefit. |
lgrossi
force-pushed
the
beats-fix-and-freeQuestCPP
branch
3 times, most recently
from
69661ed to
f614712
Compare
Introduces a new Free Quests system with C++ backend integration, replacing the previous Lua-based implementation. Adds game_freequests.cpp/hpp, updates player login logic to apply free quests, and exposes Game.addFreeQuestData to Lua. Refactors quest data loading and validation, improves date/time formatting functions, and updates .gitignore and build configuration. Also fixes time formatting in database backup and tools.cpp to use chrono time points.
lgrossi
force-pushed
the
beats-fix-and-freeQuestCPP
branch
from
f614712 to
032a6db
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new Free Quests system with C++ backend integration, replacing the previous Lua-based implementation. Adds game_freequests.cpp/hpp, updates player login logic to apply free quests, and exposes Game.addFreeQuestData to Lua. Refactors quest data loading and validation, improves date/time formatting functions, and updates .gitignore and build configuration. Also fixes time formatting in database backup and tools.cpp to use chrono time points.