Skip to content

State-Safe RNG #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Conversation

thewhaleking
Copy link
Collaborator

Uses an instantiated random.Random instance to generate the random numbers/letters used for creating payload IDs rather than the hidden instantiation (see: https://docs.python.org/3/library/random.html) which can influence the state of the global random number generator used elsewhere.

CC @chain-cpu

@thewhaleking thewhaleking requested a review from a team April 15, 2025 21:04
@github-actions github-actions bot added run-bittensor-sdk-tests Runs Bittensor SDK tests. run-bittensor-cli-tests Runs BTCLI tests. labels Apr 15, 2025
@thewhaleking thewhaleking merged commit 226c3c0 into staging Apr 15, 2025
27 of 38 checks passed
@ibraheem-abe ibraheem-abe mentioned this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-bittensor-cli-tests Runs BTCLI tests. run-bittensor-sdk-tests Runs Bittensor SDK tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants