Support async key implementations #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/1.0.6
Release/1.0.7
Release/1.0.8
Release/1.0.9
Release/1.1.0
|
Will look at this today. |
thewhaleking
requested changes
Apr 16, 2025
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
|
Thanks for your review and suggested changes, I've merged them into the branch. Also, I updated the protocol with a Union annotation for the sign() return value, so the async key implementations do no produce type hint errors. |
thewhaleking
approved these changes
Apr 29, 2025
thewhaleking
added
run-bittensor-sdk-tests
|
I'm happy with this, but it keeps failing a test. I need to dig in more. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request abstracts the Keypair used to sign transactions. This allows the integration of cryptographic backends that require async calls (such as HSMs in cloud environments).
The bittensor_wallet.Keypair type is replaced by a protocol that defines its properties and methods. In
create_signed_extrinsicit is checked if the result ofsign()is awaitable, and if so the result isproperly awaited.