From 5b700558f48cfb037991a4fc0e2e59b60d6edabf Mon Sep 17 00:00:00 2001 From: Siim Kallas Date: Mon, 3 Apr 2023 11:57:06 +0300 Subject: [PATCH] chore(mysql): remove mysql from dependencies (#1445) * chore(mysql): remove mysql from dependencies * fix: import type --------- Co-authored-by: Amir Blum --- plugins/node/opentelemetry-instrumentation-mysql/package.json | 2 +- plugins/node/opentelemetry-instrumentation-mysql/src/utils.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/node/opentelemetry-instrumentation-mysql/package.json b/plugins/node/opentelemetry-instrumentation-mysql/package.json index b998f08de..abf2347ef 100644 --- a/plugins/node/opentelemetry-instrumentation-mysql/package.json +++ b/plugins/node/opentelemetry-instrumentation-mysql/package.json @@ -56,6 +56,7 @@ "@types/sinon": "10.0.13", "gts": "3.1.0", "mocha": "7.2.0", + "mysql": "2.18.1", "nyc": "15.1.0", "rimraf": "4.2.0", "sinon": "15.0.1", @@ -65,7 +66,6 @@ "dependencies": { "@opentelemetry/instrumentation": "^0.35.1", "@opentelemetry/semantic-conventions": "^1.0.0", - "mysql": "2.18.1", "@types/mysql": "2.15.19" }, "homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-mysql#readme" diff --git a/plugins/node/opentelemetry-instrumentation-mysql/src/utils.ts b/plugins/node/opentelemetry-instrumentation-mysql/src/utils.ts index 6f2e11d30..9eb7e9082 100644 --- a/plugins/node/opentelemetry-instrumentation-mysql/src/utils.ts +++ b/plugins/node/opentelemetry-instrumentation-mysql/src/utils.ts @@ -22,7 +22,7 @@ import type { Query, QueryOptions, } from 'mysql'; -import * as mysqlTypes from 'mysql'; +import type * as mysqlTypes from 'mysql'; /** * Get an SpanAttributes map from a mysql connection config object