fixing CI complaints (#1666)

* fixing psalm complaints
use rector (and psalm) to add Override attributes, and add symfony polyfill to
provide Override in earlier php versions

* fixing more psalm complaints

* more fixes

* adding stubs for deptrac
there are some things in our code that deptrac doesn't understand or are missing
for some php versions. stub them to quieten all those violation warnings

* why not cache invalid :(

* display tools versions

* fix tools cache key

* changing cache key

* dont complain about unused psalm suppressions

* suppress invalid attribute

* quieten phpstan php8.5 complaints

* revert previous commit...now other php versions complain about an unused ignore :(

* revert typecasting in metrics aggregators

* Update src/Contrib/Otlp/ProtobufSerializer.php

Co-authored-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>

* remove override stub and use the polyfill from deptrac

---------

Co-authored-by: Chris Lightfoot-Wild <github-clw@wild.me.uk>

Author: brettmc

HttpEndpointResolver.php

@@ -37,6 +37,7 @@ public static function create(?FactoryResolverInterface $httpFactoryResolver = n
         return new self($httpFactoryResolver);
     }
 
+    #[\Override]
     public function resolve(string $endpoint, string $signal): UriInterface
     {
         $components = self::parseEndpoint($endpoint);
@@ -50,6 +51,7 @@ public function resolve(string $endpoint, string $signal): UriInterface
         );
     }
 
+    #[\Override]
     public function resolveToString(string $endpoint, string $signal): string
     {
         return (string) $this->resolve($endpoint, $signal);

LogsExporter.php

@@ -36,6 +36,7 @@ public function __construct(private TransportInterface $transport)
     /**
      * @param iterable<ReadableLogRecord> $batch
      */
+    #[\Override]
     public function export(iterable $batch, ?CancellationInterface $cancellation = null): FutureInterface
     {
         return $this->transport
@@ -70,11 +71,13 @@ public function export(iterable $batch, ?CancellationInterface $cancellation = n
             });
     }
 
+    #[\Override]
     public function forceFlush(?CancellationInterface $cancellation = null): bool
     {
         return $this->transport->forceFlush($cancellation);
     }
 
+    #[\Override]
     public function shutdown(?CancellationInterface $cancellation = null): bool
     {
         return $this->transport->shutdown($cancellation);

LogsExporterFactory.php

@@ -25,6 +25,7 @@ public function __construct(private readonly ?TransportFactoryInterface $transpo
     /**
      * @psalm-suppress ArgumentTypeCoercion
      */
+    #[\Override]
     public function create(): LogRecordExporterInterface
     {
         $protocol = Configuration::has(Variables::OTEL_EXPORTER_OTLP_LOGS_PROTOCOL)

MetricConverter.php

@@ -214,6 +214,9 @@ private function convertHistogramDataPoint(SDK\Metrics\Data\HistogramDataPoint $
         return $pHistogramDataPoint;
     }
 
+    /**
+     * @psalm-suppress PossiblyFalseArgument
+     */
     private function convertExemplar(SDK\Metrics\Data\Exemplar $exemplar): Exemplar
     {
         $pExemplar = new Exemplar();

MetricExporter.php

@@ -37,11 +37,13 @@ public function __construct(
         $this->serializer = ProtobufSerializer::forTransport($this->transport);
     }
 
+    #[\Override]
     public function temporality(MetricMetadataInterface $metric): Temporality|string|null
     {
         return $this->temporality ?? $metric->temporality();
     }
 
+    #[\Override]
     public function export(iterable $batch): bool
     {
         return $this->transport
@@ -77,11 +79,13 @@ public function export(iterable $batch): bool
             ->await();
     }
 
+    #[\Override]
     public function shutdown(): bool
     {
         return $this->transport->shutdown();
     }
 
+    #[\Override]
     public function forceFlush(): bool
     {
         return $this->transport->forceFlush();

MetricExporterFactory.php

@@ -26,6 +26,7 @@ public function __construct(private readonly ?TransportFactoryInterface $transpo
     /**
      * @psalm-suppress ArgumentTypeCoercion
      */
+    #[\Override]
     public function create(): MetricExporterInterface
     {
         $protocol = Configuration::has(Variables::OTEL_EXPORTER_OTLP_METRICS_PROTOCOL)

OtlpHttpTransportFactory.php

@@ -12,6 +12,7 @@ class OtlpHttpTransportFactory implements TransportFactoryInterface
 {
     private const DEFAULT_COMPRESSION = 'none';
 
+    #[\Override]
     public function create(
         string $endpoint,
         string $contentType,

ProtobufSerializer.php

@@ -19,6 +19,7 @@
 use const JSON_UNESCAPED_SLASHES;
 use const JSON_UNESCAPED_UNICODE;
 use function lcfirst;
+use OpenTelemetry\API\Behavior\LogsMessagesTrait;
 use OpenTelemetry\SDK\Common\Export\TransportInterface;
 use function property_exists;
 use function sprintf;
@@ -30,6 +31,8 @@
  */
 final class ProtobufSerializer
 {
+    use LogsMessagesTrait;
+
     private function __construct(private readonly string $contentType)
     {
     }
@@ -117,11 +120,14 @@ private static function serializeToJsonString(Message $message): string
             return $payload;
         }
 
-        $data = json_decode($payload);
+        $data = json_decode((string) $payload);
         unset($payload);
         self::traverseDescriptor($data, $desc);
 
-        return json_encode($data, JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE);
+        $encoded = json_encode($data, JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE);
+        assert($encoded !== false);
+
+        return $encoded;
     }
 
     private static function traverseDescriptor(object $data, Descriptor $desc): void

SpanExporter.php

@@ -32,6 +32,7 @@ public function __construct(private TransportInterface $transport)
         $this->serializer = ProtobufSerializer::forTransport($this->transport);
     }
 
+    #[\Override]
     public function export(iterable $batch, ?CancellationInterface $cancellation = null): FutureInterface
     {
         return $this->transport
@@ -66,11 +67,13 @@ public function export(iterable $batch, ?CancellationInterface $cancellation = n
             });
     }
 
+    #[\Override]
     public function shutdown(?CancellationInterface $cancellation = null): bool
     {
         return $this->transport->shutdown($cancellation);
     }
 
+    #[\Override]
     public function forceFlush(?CancellationInterface $cancellation = null): bool
     {
         return $this->transport->forceFlush($cancellation);

SpanExporterFactory.php

@@ -28,6 +28,7 @@ public function __construct(private readonly ?TransportFactoryInterface $transpo
     /**
      * @psalm-suppress ArgumentTypeCoercion
      */
+    #[\Override]
     public function create(): SpanExporterInterface
     {
         $transport = $this->buildTransport();