fix(sdk): newGranter nil check #2729
Conversation
github-actions
bot
added
the
comp:sdk
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @pflynn-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the robustness of the newGranter function by refining its error handling mechanism. The core improvement ensures that any error encountered during the granter's initialization is promptly propagated, thereby safeguarding against the use of partially constructed or invalid objects and improving overall system reliability.
Highlights
- Improved Error Handling: An early return has been added to the
newGranterfunction. If an error occurs during the granter creation, the function now immediately returns the error, preventing subsequent operations on a potentially invalid object. - Preventing Invalid State: This change specifically prevents the
g.keyInfoFetcherfield from being assigned when an error has already occurred, ensuring the granter object remains in a consistent state.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Error checks now swift, Invalid state avoided, Code runs clean and safe.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a small but important fix to the error handling in the newGranter function. By adding an early return when an error is encountered during granter creation, it prevents further operations on a potentially uninitialized granter object. This improves the robustness and correctness of the code. The change is well-targeted and correct. I have no further comments.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
|
the perils of 'extract function' refactoring |
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
🤖 I have created a release *beep* *boop* --- ## [0.8.0](sdk/v0.7.0...sdk/v0.8.0) (2025-09-19) ### Features * **policy:** obligations + values CRUD ([#2545](#2545)) ([c194e35](c194e35)) ### Bug Fixes * **deps:** bump github.com/opentdf/platform/lib/ocrypto from 0.3.0 to 0.5.0 in /sdk ([#2693](#2693)) ([b511048](b511048)) * **deps:** bump github.com/opentdf/platform/lib/ocrypto from 0.5.0 to 0.6.0 in /sdk ([#2712](#2712)) ([74956bf](74956bf)) * **deps:** bump github.com/opentdf/platform/protocol/go from 0.7.0 to 0.8.0 in /sdk ([#2692](#2692)) ([fac2ef2](fac2ef2)) * **deps:** bump github.com/opentdf/platform/protocol/go from 0.8.0 to 0.9.0 in /sdk ([#2724](#2724)) ([e07cc91](e07cc91)) * **deps:** bump github.com/opentdf/platform/protocol/go from 0.9.0 to 0.10.0 in /sdk ([#2737](#2737)) ([f4a8d1d](f4a8d1d)) * **sdk:** newGranter nil check ([#2729](#2729)) ([a1bebc5](a1bebc5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
This pull request makes a targeted fix to the error handling logic in the
newGranterfunction withinsdk/tdf.go. The change ensures that if an error occurs while creating the granter, the function immediately returns the error, preventing further operations on a potentially invalid object.Error handling improvement:
newGranterfunction to immediately return iferris not nil, improving reliability and preventing assignment tog.keyInfoFetcherwhen an error occurs. (sdk/tdf.go, sdk/tdf.goR458-R460