Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement editing result view code update range mapping #2042

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Dec 5, 2022

Types

  • 🎉 New Features

Background or solution

在每次新增行或删减行时,重新计算 3 个视图中 document mapping 的对应关系,使其 diff 区域能对应上

Kapture.2022-12-05.at.16.42.21.mp4

Changelog

支持在编辑 result 视图中的代码时动态更新 diff 区域范围

@Ricbet Ricbet self-assigned this Dec 5, 2022
@github-actions github-actions bot added the 🎨 feature feature required label Dec 5, 2022
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ricbet Ricbet merged commit 68c62bc into feat/implement-3-way-editor Dec 5, 2022
@Ricbet Ricbet deleted the feat/dynamic-rang-mapping branch December 5, 2022 14:27
Ricbet added a commit that referenced this pull request Dec 19, 2022
* fix: render dashed in accept current conflict

* feat: implement editing result view code update range mapping

* fix: result editor view update decorations
Ricbet added a commit that referenced this pull request Dec 20, 2022
* fix: render dashed in accept current conflict

* feat: implement editing result view code update range mapping

* fix: result editor view update decorations
Ricbet added a commit that referenced this pull request Dec 20, 2022
* fix: render dashed in accept current conflict

* feat: implement editing result view code update range mapping

* fix: result editor view update decorations
Ricbet added a commit that referenced this pull request Dec 21, 2022
* fix: render dashed in accept current conflict

* feat: implement editing result view code update range mapping

* fix: result editor view update decorations
Ricbet added a commit that referenced this pull request Dec 22, 2022
* fix: render dashed in accept current conflict

* feat: implement editing result view code update range mapping

* fix: result editor view update decorations
Ricbet added a commit that referenced this pull request Dec 27, 2022
* fix: render dashed in accept current conflict

* feat: implement editing result view code update range mapping

* fix: result editor view update decorations
Ricbet added a commit that referenced this pull request Dec 28, 2022
* fix: render dashed in accept current conflict

* feat: implement editing result view code update range mapping

* fix: result editor view update decorations
erha19 pushed a commit that referenced this pull request Dec 28, 2022
* feat: implement 3-way prototyping code

* feat: implement compute diff

* feat: add underline widget

* fix: context key service error

* feat: improve code & implement 3 editor model

* chore: improve code & implement render different color

* chore: improve code

* chore: implement scroll change sync

* chore: improve code

* feat: implement inner changes decoration render (#1987)

* fix: result editor view line widget render error

* feat: implement inner changes char decoration render

* chore: improve code

* refactor: merge editor cyrcle deps (#1992)

* refactor: merge editor cyrcle deps

* fix: model

* feat: implement stickiness connect effect (#1994)

* feat: draw stickiness connect piece

* feat: implement stickiness-connect move position

* chore: rebase

* chore: improve code & fix zonewidget

* chore: improve code

* feat: alternate margin and code view (#1995)

* feat: render conflict actions (#2002)

* feat: implement conflict actions base code

* chore: improve code

* feat: implement conflict actions operations (#2014)

* feat: implement conflict actions operations

* feat: implement conflict actions operations

* refactor: decorations type

* fix: conflict-actions

* chore: improve code

* refactor: document mapping

* chore: rename type

* chore: add note

* fix: type

* feat: implement conflict ignore actions operations (#2031)

* feat: implement conflict ignore actions operations

* chore: remove useless file

* feat: implement dashed decorations render (#2033)

* feat: implement dashed line render

* chore: improve code

* feat: implement editing result view code update range mapping (#2042)

* fix: render dashed in accept current conflict

* feat: implement editing result view code update range mapping

* fix: result editor view update decorations

* style: beauty merge editor diff range (#2046)

* feat: implement revoke conflict actions (#2065)

* refactor: conflict actions

* feat: result view editor conflict action render

* chore: add revoke icon

* feat: implement revoke actions

* fix: delta edits

* feat: implement contiguous region merge range (#2076)

* refactor: diff line range render

* feat: improve diff merge range render

* chore: improve code

* feat: implement accept combination conflict actions (#2079)

* feat: implement accept combination render

* feat: implement accept combination actions

* chore: improve mark complete code

* chore: improve code

* feat: improve conflict action (#2082)

* fix: turn direction status

* fix: range touch condition

* chore: improve actions update render & fix revoke actions

* feat: implement append action render & fix mapping data

* chore: rename sameRange symbol

* style: improve append icon

* feat: implement accept append action

* chore: remove console

* fix: merge editor options (#2038)

* fix: merge editor options

* fix: merge editor options

Co-authored-by: qingyi.xjh <qingyi.xjh@antgroup.com>

* fix: accept combination apply edits error (#2085)

* fix: accept combination apply edits error

* chore: improve code

* feat: support open from git scm (#2094)

* feat: show title head info & implement the apply actions (#2095)

* feat: implement title head & fix scroll & keep view state

* feat: implement apply action

* fix: time machine record

* docs: apply button i18n

* chore: improve code

* fix: ci

* fix: add merge editor mock test

* fix: ci

* style: use css module (#2101)

* fix: e2e test

* chore: add test

* chore: add tst

Co-authored-by: 大表哥 <xubing.bxb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants