Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Potlatch 2.2 does not discard a way's first point when Undo-ing it #3860

Open
openstreetmap-trac opened this issue Jul 23, 2021 · 6 comments

Comments

@openstreetmap-trac
Copy link

Reporter: Pepou
[Submitted to the original trac issue database at 5.11pm, Friday, 24th June 2011]

Click two or more points (=n'') on map - a way connecting clicked points is being created. After (''n-1) Undo's the way is gone, but the initial point still remains visible (a green dot) and the Undo button is already grayed out - one step got forgot.

It is possible to delete the point manually (red (x) button), but it should be also deleted by the ''n''-th Undo.

@openstreetmap-trac
Copy link
Author

Author: Nop
[Added to the original trac issue at 4.22pm, Monday, 27th June 2011]

I observe this behaviour regularly. All that's needed is to create a two-node way and press undo once. This happens quite frequently when I try to drag the visible area but somehow P2 recognizes clicks instead of the drag. I think this is a major nuisance as it tends to create nonsensical empty nodes if you don't spot the problem and delete them manually. Does it break the undo system if such ghost objects are left over?

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 2.17pm, Saturday, 3rd March 2012]

Fixed. Ow. That was a lot harder than I expected.

systemed/potlatch2#33

@openstreetmap-trac
Copy link
Author

Author: Pepou
[Added to the original trac issue at 8.40am, Tuesday, 6th March 2012]

Thanks, it was indeed a frequent nuisance.

@openstreetmap-trac
Copy link
Author

Author: malenki
[Added to the original trac issue at 1.22pm, Saturday, 23rd February 2013]

The misbehaviour is still/again there. Node cannot be deleted using either undo-button or ctrl-z

@openstreetmap-trac
Copy link
Author

Author: stevage
[Added to the original trac issue at 12.52pm, Monday, 25th February 2013]

Yes. Although I submitted a pull request with the bug fix, it has not been accepted by the maintainer of Potlatch 2, Richard Fairhurst. I suggest you ask him politely about it.

@openstreetmap-trac
Copy link
Author

Author: malenki
[Added to the original trac issue at 10.37am, Saturday, 23rd March 2013]

#4406 seems a duplicate of this bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant