Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to api/0.6/user/gpx_files #3560

Open
mmd-osm opened this issue Jun 3, 2022 · 1 comment
Open

Add pagination to api/0.6/user/gpx_files #3560

mmd-osm opened this issue Jun 3, 2022 · 1 comment
Labels
api Related to the XML or JSON APIs

Comments

@mmd-osm
Copy link
Collaborator

mmd-osm commented Jun 3, 2022

As @systemed noted in systemed/potlatch3#34:

Ultimately then I guess this is an openstreetmap-website issue. As best I know, the /api/0.6/user/gpx_files call doesn't support pagination.

which seems to match: https://github.com/openstreetmap/openstreetmap-website/blob/master/app/controllers/api/users_controller.rb#L53

As some users might have a pretty large number of GPX traces, downloading all metadata at once might be quite time and resource consuming.

@tomhughes
Copy link
Member

tomhughes commented Jun 3, 2022

Please note that there is a ban in place on straightforward pagination and no PRs will be accepted which attempt to add it.

Pagination based on an indexed field like ID or a date that has been indexed is fine but a simple page number that refers to an ordered result set is not acceptable.

@mmd-osm mmd-osm added the api Related to the XML or JSON APIs label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the XML or JSON APIs
Projects
None yet
Development

No branches or pull requests

2 participants