Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links in GNIS Feature ID field #272

Closed
1ec5 opened this issue Nov 15, 2021 · 5 comments
Closed

Broken links in GNIS Feature ID field #272

1ec5 opened this issue Nov 15, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 15, 2021

The USGS has sunsetted the GeoNames domestic name lookup tool that the GNIS Feature ID field links to:

"urlFormat": "https://geonames.usgs.gov/apex/f?p=gnispq:3:::NO::P3_FID:{value}",

These URLs now redirect to a landing page, which explains that many of the GNIS feature classes that had been imported into OSM have been archived and will no longer be searchable online. They remain downloadable in a data dump, but that isn’t helpful for this field. The feature classes were archived because of being unmaintained, but many of the features are still extant (example).

For the feature classes that haven’t been archived, a new search tool is available, but its permalinks include a UUID that’s unrelated to the GNIS feature ID. I’m unsure if the search form can take the feature ID as a query parameter.

The National Map program also has a MapServer containing GeoNames, but you can only query one layer at a time, and it doesn’t contain all the metadata that’s in the main search tool. It probably also doesn’t include the archived feature classes.

@jleedev
Copy link

jleedev commented Nov 15, 2021

The link button in the upper corner of that site gives a reasonable-looking URL:

https://edits.nationalmap.gov/apps/gaz-domestic/public/summary/1187058

@1ec5
Copy link
Contributor Author

1ec5 commented Nov 15, 2021

Thanks, that would be a clean replacement for the old URL format. Still, I’m a bit concerned about the legacy feature classes being archived: if users get the idea that this link helps to verify the veracity of a GNIS feature ID, then seeing a false negative “not found” could lead to some POIs getting unnecessarily deleted, or at least their feature IDs getting untagged. Maybe we should import the rest of GNIS into Wikidata (beyond the parks and populated places) and link there instead.

@jleedev
Copy link

jleedev commented Nov 15, 2021

For context, NationalFile_20210825.txt contains 2279130 records, and Wikidata contains 670610 statements of p:P590.

@tyrasd tyrasd added the waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques label Jan 7, 2022
@tyrasd
Copy link
Member

tyrasd commented Jan 7, 2022

I'm not sure how to best proceed here. Should we use the new url (https://edits.nationalmap.gov/apps/gaz-domestic/public/summary/…?)? Or would it be better to drop the link for now until a better solution is found?

@tyrasd tyrasd added the bug Something isn't working label Jan 7, 2022
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 8, 2022

For now, I guess the National Map URL is better than the current broken link. One way to allay the concern about the deleted categories would be to stand up a Web-based tool that can display the metadata and description from the GNIS dump given a feature ID. It might be easier than figuring out the logistics of importing the POIs into Wikidata and conflating them with existing Wikidata items. But standing up that tool wouldn’t be your responsibility; we can always update the link once it’s available.

@tyrasd tyrasd removed the waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques label Jan 10, 2022
@tyrasd tyrasd closed this as completed in 61cffa2 Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants