-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regional presets for german cycleway tagging #267
Comments
I added the "Fahrradstraße" bicycle road to the list of additional presets. |
I updated the issue with what I learned about the locationSet feature and clarified the general question about those presets. |
Sure, why not! Btw. related is also #109. |
@tyrasd would love to hear your thoughts on those regional bike presets. There where quite a few tickets here and in iD and the schema repo which are related to this in the sense, that regional presets cause some issues. And working on #345 I had the same feeling, that those presets might stretch the current setup too much. However, I want to get them going as well since they add a lot of clarity and enable good data. So my question is: What are your thoughts which tickets need to be solved before adding more of those regional presets? And do you have plans to tackle those tickets in the near future (from your personal roadmap point of view)? (Please let me know if this was too vague and I will go into more details.) |
I am thinking about adding regional presets for cycleways in Germany … – Any thoughts on this? Would such a PR be merged?
Presets I am considering:
See Add presets for German bicycle DE:240 #345
They describe very specific tagging for footways with access rules for bikes.
The traffic sign could be part of the icon and also added as part of the preset.
I think having a clear name in iD (…) for a way with this tagging would be helpful.
Notes about regional presets:
(Thanks to a comment by Bryan)
Presets and fields support a
locationSet
to include/exclude countries.locationSet: { include: ["de"] }
locationSet: { exclude: ["de"] }
The code in iD (https://github.com/openstreetmap/iD/pull/8305/files#diff-f38480d9980a09d7046b627edd05069ed2b53e545697888c66b697e855b8d886R10-R22) uses the location-conflation module https://github.com/ideditor/location-conflation#what-is-it which in turn allows uses country-coder https://github.com/ideditor/country-coder#what-is-it which allows all kinds of regional identifiers.
Quick link to a search result list of presets and fields that use this feature right now: https://github.com/openstreetmap/id-tagging-schema/search?q=locationSet
The text was updated successfully, but these errors were encountered: