Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inscription=* should not update to memorial:text=* on memorial=stolperstein #1372

Closed
wielandb opened this issue Nov 2, 2024 · 4 comments
Closed

Comments

@wielandb
Copy link

wielandb commented Nov 2, 2024

Lines to be changed/removed:
https://github.com/openstreetmap/id-tagging-schema/blob/135ad24d0d1b92496d1cf7a6e5a358ea50ccdd7f/data/deprecated.json#L1995C1-L1998C5

There seems to be a consensus that inscription= is indeed the correct way to tag what is written on a stolperstein, as every wiki page mentions it like that.

@wielandb wielandb changed the title inscription=* should not update to memorial:text=* on ``memorial=stolperstein inscription=* should not update to memorial:text=* on memorial=stolperstein Nov 2, 2024
@tordans
Copy link
Collaborator

tordans commented Nov 2, 2024

Quick side note: I am pretty sure is researched this for the initial PR that added the preset. And discussed it it somewhere to find this recommendation.

@matkoniecz
Copy link
Contributor

inscription=* should not update to memorial:text=*

maybe I misread linked rule, but it seems to change "old": {"memorial:text": "*"}, TO inscription

@matkoniecz
Copy link
Contributor

screen02

inscription=* should not update to memorial:text=*

already done, can you close the issue?

@tordans
Copy link
Collaborator

tordans commented Nov 3, 2024

Thanks for taking a look @matkoniecz. I agree that this should be all good and working as intended.

For reference, those are the PR #964 and Issue #318 which holds quite a bit of research on this preset because the tagging was a mess when we started this.

@tordans tordans closed this as completed Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants